Skip to content

Commit c04f12e

Browse files
authored
ci: resolve issue where docs failures do not appear in presubmits (#12312)
A bug was introduced in #12273 and #12274 which prevents docs failures from appearing in presubmits
1 parent c23398a commit c04f12e

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

ci/run_single_test.sh

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,21 +50,25 @@ case ${TEST_TYPE} in
5050
;;
5151
docs)
5252
nox -s docs
53+
# This line needs to be directly after `nox -s docs` in order
54+
# for the failure to appear in Github presubmits
55+
retval=$?
5356
# Clean up built docs and python cache after the build process to avoid
5457
# `[Errno 28] No space left on device`
5558
# See https://github.com/googleapis/google-cloud-python/issues/12271
5659
rm -rf docs/_build
5760
find . | grep -E "(__pycache__)" | xargs rm -rf
58-
retval=$?
5961
;;
6062
docfx)
6163
nox -s docfx
64+
# This line needs to be directly after `nox -s docfx` in order
65+
# for the failure to appear in Github presubmits
66+
retval=$?
6267
# Clean up built docs and python cache after the build process to avoid
6368
# `[Errno 28] No space left on device`
6469
# See https://github.com/googleapis/google-cloud-python/issues/12271
6570
rm -rf docs/_build
6671
find . | grep -E "(__pycache__)" | xargs rm -rf
67-
retval=$?
6872
;;
6973
prerelease)
7074
nox -s prerelease_deps-3.12

0 commit comments

Comments
 (0)