Commit 66794a0
chore(bigtable): Rerouted legacy client row filters to data client row filters (#18175)
Migrating over @gkevinzheng PR from bigtable monorepo
googleapis/python-bigtable#1255
### Original description:
> Changes made:
> - Used import aliasing to remove most of the legacy client row filter
code and use the data client row filter code in its place.
> - Some of the data client row filter classes had to be slightly
modified for backwards compatibility with the legacy client row filter
classes' interface.
> - As part of this move, `to_pb` has been replaced with `_to_pb`, and I
have adjusted references to `<RowFilter>.to_pb` in the libraries and
unit tests.
>
> This is for eventually shimming up `CheckAndMutateRows`, and other row
mutation operations as well.
### Additional changes on top of Kevin's:
-
([3097276](3097276))
I added an alias between the new `_to_pb()` and the old `to_pb()`
methods, for backwards compatibility
- Originally, we were planning on dropping the method. Now, it can still
be used, with a deprecation warning
Note to reviewers: This PR has already been reviewed and merged to a
staging branch, with the intention of doing a single merge to main. We
are now planning to slowly rollout these changes back to the main
branch. Minimal re-review should be necessary
---------
Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com>1 parent 199aabd commit 66794a0
7 files changed
Lines changed: 248 additions & 849 deletions
File tree
- packages/google-cloud-bigtable
- google/cloud/bigtable
- tests/unit/v2_client
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
231 | 231 | | |
232 | 232 | | |
233 | 233 | | |
234 | | - | |
| 234 | + | |
235 | 235 | | |
236 | 236 | | |
237 | 237 | | |
| |||
602 | 602 | | |
603 | 603 | | |
604 | 604 | | |
605 | | - | |
| 605 | + | |
606 | 606 | | |
607 | 607 | | |
608 | 608 | | |
| |||
0 commit comments