Skip to content

Commit 0e00c4b

Browse files
fix(compute): revert proto3_optional, required removal on parent_id (#714) (#717)
* fix(compute): revert proto3_optional, required removal on parent_id (#714) Source-Link: googleapis/googleapis@6b3fdce Source-Link: googleapis/googleapis-gen@832dbe9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODMyZGJlOTk4ODc4ZDg2MTlkNmI0MGZlNTdjNmQyY2M2ZTdkYzkwYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent b570c09 commit 0e00c4b

6 files changed

Lines changed: 17 additions & 35 deletions

File tree

packages/google-cloud-compute/protos/google/cloud/compute/v1/compute.proto

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16439,7 +16439,10 @@ message MoveFirewallPolicyRequest {
1643916439
string firewall_policy = 498173265 [(google.api.field_behavior) = REQUIRED];
1644016440

1644116441
// The new parent of the firewall policy.
16442-
optional string parent_id = 459714768 [(google.cloud.operation_request_field) = "parent_id"];
16442+
string parent_id = 459714768 [
16443+
(google.api.field_behavior) = REQUIRED,
16444+
(google.cloud.operation_request_field) = "parent_id"
16445+
];
1644316446

1644416447
// An optional request ID to identify requests. Specify a unique request ID so that if you must retry your request, the server will know to ignore the request if it has already been completed. For example, consider a situation where you make an initial request and the request times out. If you make the request again with the same request ID, the server can check if original operation with the same request ID was received, and if so, will ignore the second request. This prevents clients from accidentally creating duplicate commitments. The request ID must be a valid UUID with the exception that zero UUID is not supported ( 00000000-0000-0000-0000-000000000000).
1644516448
optional string request_id = 37109963;

packages/google-cloud-compute/protos/protos.d.ts

Lines changed: 1 addition & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/google-cloud-compute/protos/protos.js

Lines changed: 7 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/google-cloud-compute/protos/protos.json

Lines changed: 2 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/google-cloud-compute/samples/generated/v1/firewall_policies.move.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
'use strict';
2222

23-
function main(firewallPolicy) {
23+
function main(firewallPolicy, parentId) {
2424
// [START compute_v1_generated_FirewallPolicies_Move_async]
2525
/**
2626
* TODO(developer): Uncomment these variables before running the sample.
@@ -48,6 +48,7 @@ function main(firewallPolicy) {
4848
// Construct request
4949
const request = {
5050
firewallPolicy,
51+
parentId,
5152
};
5253

5354
// Run request

packages/google-cloud-compute/samples/generated/v1/snippet_metadata.google.cloud.compute.v1.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3662,7 +3662,7 @@
36623662
"segments": [
36633663
{
36643664
"start": 25,
3665-
"end": 58,
3665+
"end": 59,
36663666
"type": "FULL"
36673667
}
36683668
],

0 commit comments

Comments
 (0)