fix race in FakeSubscriberServiceImpl (#1592)

pongad · web-flow · commit 709d21d9d1e6 · 2017-02-07T13:38:33.000+11:00
This is the same race as #1495 but in sendStreamResponse rather than sendError.
diff --git a/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/spi/v1/FakeSubscriberServiceImpl.java b/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/spi/v1/FakeSubscriberServiceImpl.java
@@ -208,6 +208,7 @@ public void sendStreamingResponse(StreamingPullResponse pullResponse)
       throws InterruptedException {
     waitForRegistedSubscription();
     synchronized (openedStreams) {
+      waitForOpenedStreams(1);
       openedStreams.get(getAndAdvanceCurrentStream()).responseObserver.onNext(pullResponse);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -208,6 +208,7 @@ public void sendStreamingResponse(StreamingPullResponse pullResponse)`
`208`	`208`	`throws InterruptedException {`
`209`	`209`	`waitForRegistedSubscription();`
`210`	`210`	`synchronized (openedStreams) {`
	`211`	`+ waitForOpenedStreams(1);`
`211`	`212`	`openedStreams.get(getAndAdvanceCurrentStream()).responseObserver.onNext(pullResponse);`
`212`	`213`	`}`
`213`	`214`	`}`