Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Commit efec9da

Browse files
more visibility fixes
1 parent f7de26d commit efec9da

2 files changed

Lines changed: 12 additions & 12 deletions

File tree

gax-grpc/src/main/java/com/google/api/gax/grpc/GrpcExceptionServerStreamingCallable.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public ExceptionResponseObserver(ResponseObserver<ResponseT> innerObserver) {
7171
}
7272

7373
@Override
74-
public void onStartImpl(final StreamController controller) {
74+
protected void onStartImpl(final StreamController controller) {
7575
innerObserver.onStart(
7676
new StreamController() {
7777
@Override
@@ -93,12 +93,12 @@ public void request(int count) {
9393
}
9494

9595
@Override
96-
public void onResponseImpl(ResponseT response) {
96+
protected void onResponseImpl(ResponseT response) {
9797
innerObserver.onResponse(response);
9898
}
9999

100100
@Override
101-
public void onErrorImpl(Throwable t) {
101+
protected void onErrorImpl(Throwable t) {
102102
if (cancellationException != null) {
103103
t = cancellationException;
104104
} else {
@@ -108,7 +108,7 @@ public void onErrorImpl(Throwable t) {
108108
}
109109

110110
@Override
111-
public void onCompleteImpl() {
111+
protected void onCompleteImpl() {
112112
innerObserver.onComplete();
113113
}
114114
}

gax-grpc/src/test/java/com/google/api/gax/grpc/GrpcDirectServerStreamingCallableTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -206,20 +206,20 @@ public void testObserverErrorCancelsCall() throws Throwable {
206206
ResponseObserver<Money> moneyObserver =
207207
new AbstractResponseObserver<Money>() {
208208
@Override
209-
public void onStartImpl(StreamController controller) {}
209+
protected void onStartImpl(StreamController controller) {}
210210

211211
@Override
212-
public void onResponseImpl(Money response) {
212+
protected void onResponseImpl(Money response) {
213213
throw expectedCause;
214214
}
215215

216216
@Override
217-
public void onErrorImpl(Throwable t) {
217+
protected void onErrorImpl(Throwable t) {
218218
actualErrorF.set(t);
219219
}
220220

221221
@Override
222-
public void onCompleteImpl() {
222+
protected void onCompleteImpl() {
223223
actualErrorF.set(null);
224224
}
225225
};
@@ -262,27 +262,27 @@ private static class MoneyObserver extends AbstractResponseObserver<Money> {
262262
}
263263

264264
@Override
265-
public void onStartImpl(StreamController controller) {
265+
protected void onStartImpl(StreamController controller) {
266266
this.controller = controller;
267267
if (!autoFlowControl) {
268268
controller.disableAutoInboundFlowControl();
269269
}
270270
}
271271

272272
@Override
273-
public void onResponseImpl(Money value) {
273+
protected void onResponseImpl(Money value) {
274274
response = value;
275275
latch.countDown();
276276
}
277277

278278
@Override
279-
public void onErrorImpl(Throwable t) {
279+
protected void onErrorImpl(Throwable t) {
280280
error = t;
281281
latch.countDown();
282282
}
283283

284284
@Override
285-
public void onCompleteImpl() {
285+
protected void onCompleteImpl() {
286286
completed = true;
287287
latch.countDown();
288288
}

0 commit comments

Comments
 (0)