This repository was archived by the owner on Mar 26, 2026. It is now read-only.
fix: s/grpcAsync/grpc-async for gapic metadata#803
Merged
gcf-merge-on-green[bot] merged 1 commit intoMar 4, 2021
Conversation
As discussed in the design doc, the agreed upon naming convention for the the asynchronous variants in gapic metadata use kebab-case instead of Pascal case.
software-dov
requested review from
a team,
arithmetic1728,
busunkim96 and
vchudnov-g
software-dov
added
the
automerge
google-cla
Bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #803 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 27 +1
Lines 1608 1649 +41
Branches 328 337 +9
=========================================
+ Hits 1608 1649 +41
Continue to review full report at Codecov.
|
arithmetic1728
approved these changes
Mar 4, 2021
gcf-merge-on-green
Bot
removed
the
automerge
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Mar 5, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [0.42.2](https://www.github.com/googleapis/gapic-generator-python/compare/v0.42.1...v0.42.2) (2021-03-05) ### Bug Fixes * s/grpcAsync/grpc-async for gapic metadata ([#803](https://www.github.com/googleapis/gapic-generator-python/issues/803)) ([96f7864](https://www.github.com/googleapis/gapic-generator-python/commit/96f78640d90cf50c6b525924d14c6afe31874be6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in the design doc, the agreed upon naming convention for
the the asynchronous variants in gapic metadata use kebab-case instead
of Pascal case.