fix(core): sanitize and remove hardcoded Google CrUX API key in chrome-devtools-mcp (#29158)

Author: amelidev

packages/cli/src/ui/components/__snapshots__/BackgroundTaskDisplay.test.tsx.snap

@@ -25,6 +25,21 @@ exports[`<BackgroundTaskDisplay /> > keeps exit code status color even when sele
 "
 `;
 
+exports[`<BackgroundTaskDisplay /> > keeps exit code status color even when selected 2`] = `
+"┌──────────────────────────────────────────────────────────────────────────────┐
+│  1: npm sta.. (PID: 1003)        Close (Ctrl+B) | Kill (Ctrl+K) | List       │
+│              (Focused)           (Ctrl+L)                                    │
+│                                                                              │
+│ Select Process (Enter to select, Ctrl+K to kill, Esc to cancel):             │
+│                                                                              │
+│   1. npm start (PID: 1001)                                                   │
+│   2. tail -f log.txt (PID: 1002)                                             │
+│ ● 3. exit 0 (PID: 1003) (Exit Code: 0)                                       │
+│ Log: ~/.gemini/tmp/background-processes/background-1003.log                  │
+└──────────────────────────────────────────────────────────────────────────────┘
+"
+`;
+
 exports[`<BackgroundTaskDisplay /> > renders tabs for multiple shells 1`] = `
 "┌──────────────────────────────────────────────────────────────────────────────────────────────────┐
 │  1: npm start  2: tail -f lo...  (PID: 1001)      Close (Ctrl+B) | Kill (Ctrl+K) | List (Ctrl+L) │

packages/cli/src/ui/components/__snapshots__/InputPrompt.test.tsx.snap

@@ -169,6 +169,12 @@ exports[`InputPrompt > multiline rendering > should correctly render multiline i
 ────────────────────────────────────────────────────────────────────────────────────────────────────"
 `;
 
+exports[`InputPrompt > should still allow input when shell is not focused 1`] = `
+"▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
+ >   Type your message or @path/to/file                                                             
+▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀"
+`;
+
 exports[`InputPrompt > snapshots > should not show inverted cursor when shell is focused 1`] = `
 "▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
  >   Type your message or @path/to/file                                                             

packages/cli/src/ui/components/messages/__snapshots__/DiffRenderer.test.tsx.snap

@@ -84,6 +84,16 @@ exports[`<OverflowProvider><DiffRenderer /></OverflowProvider> > with useAlterna
 "
 `;
 
+exports[`<OverflowProvider><DiffRenderer /></OverflowProvider> > with useAlternateBuffer = false > should render a gap indicator for skipped lines 2`] = `
+" 1   context line 1
+ 2 - deleted line
+ 2 + added line
+════════════════════════════════════════════════════════════════════════════════
+10   context line 10
+11   context line 11
+"
+`;
+
 exports[`<OverflowProvider><DiffRenderer /></OverflowProvider> > with useAlternateBuffer = false > should render diff content for existing file (not calling colorizeCode directly for the whole block) 1`] = `
 "1 - old line
 1 + new line

packages/core/scripts/bundle-browser-mcp.mjs

@@ -95,6 +95,44 @@ async function bundle() {
     } else {
       console.warn(`Warning: third_party assets not found at ${srcThirdParty}`);
     }
+
+    // Sanitize any hardcoded sensitive API keys in the bundled and copied output files.
+    // Replace the plaintext Google CrUX API key with dynamic process.env lookup at runtime.
+    const bundleMcpFile = path.resolve(
+      __dirname,
+      '../dist/bundled/chrome-devtools-mcp.mjs',
+    );
+    const destThirdPartyIndex = path.resolve(
+      __dirname,
+      '../dist/bundled/third_party/index.js',
+    );
+
+    const sanitizeFile = (filePath) => {
+      if (fs.existsSync(filePath)) {
+        const content = fs.readFileSync(filePath, 'utf8');
+        const keyPattern = /AIzaSy[A-Za-z0-9_-]{30,40}/;
+        if (keyPattern.test(content)) {
+          console.log(`Sanitizing hardcoded API key in: ${filePath}`);
+          // Replace single-quoted, double-quoted, and backtick occurrences of any matching Google API key with process.env lookup
+          const quotedPattern = /([\x27\x22\x60])AIzaSy[A-Za-z0-9_-]{30,40}\1/g;
+          const sanitizedContent = content.replace(
+            quotedPattern,
+            '(process.env.CRUX_API_KEY || "")',
+          );
+
+          if (keyPattern.test(sanitizedContent)) {
+            throw new Error(
+              `Failed to fully sanitize API key in ${filePath}. The key pattern was detected but could not be safely replaced.`,
+            );
+          }
+
+          fs.writeFileSync(filePath, sanitizedContent, 'utf8');
+        }
+      }
+    };
+
+    sanitizeFile(bundleMcpFile);
+    sanitizeFile(destThirdPartyIndex);
   } catch (error) {
     console.error('Error bundling chrome-devtools-mcp:', error);
     process.exit(1);

packages/core/src/utils/cruxKeyLeak.test.ts

@@ -0,0 +1,80 @@
+/**
+ * @license
+ * Copyright 2026 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import { describe, it, expect } from 'vitest';
+import * as fs from 'node:fs';
+import * as path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const __dirname = path.dirname(fileURLToPath(import.meta.url));
+
+describe('Google CrUX API Key Leak Detection', () => {
+  const LEAKED_KEY = Buffer.from(
+    'QUl6YVN5Q0NTT3gyNXZyYjV6MHRiZWRDQjNfSlJ6emJWVzZVd2d3',
+    'base64',
+  ).toString('utf8');
+
+  it('should verify the raw node_modules dependency contains the hardcoded Google CrUX API key', () => {
+    const dependencyPath = path.resolve(
+      __dirname,
+      '../../../../node_modules/chrome-devtools-mcp/build/src/third_party/index.js',
+    );
+
+    if (fs.existsSync(dependencyPath)) {
+      const content = fs.readFileSync(dependencyPath, 'utf8');
+      expect(content).toContain(LEAKED_KEY);
+    } else {
+      throw new Error(
+        `Expected chrome-devtools-mcp source file to exist at: ${dependencyPath}`,
+      );
+    }
+  });
+
+  it('should not contain the hardcoded Google CrUX API key in bundled chrome-devtools-mcp.mjs', () => {
+    const bundleMcpPath = path.resolve(
+      __dirname,
+      '../../dist/bundled/chrome-devtools-mcp.mjs',
+    );
+
+    if (fs.existsSync(bundleMcpPath)) {
+      const content = fs.readFileSync(bundleMcpPath, 'utf8');
+      expect(content).not.toContain(LEAKED_KEY);
+    }
+  });
+
+  it('should not contain the hardcoded Google CrUX API key in bundled third_party assets', () => {
+    const thirdPartyPath = path.resolve(
+      __dirname,
+      '../../dist/bundled/third_party/index.js',
+    );
+
+    if (fs.existsSync(thirdPartyPath)) {
+      const content = fs.readFileSync(thirdPartyPath, 'utf8');
+      expect(content).not.toContain(LEAKED_KEY);
+    }
+  });
+
+  it('should not contain the hardcoded Google CrUX API key in final bundle/bundled/ directory if exists', () => {
+    const finalBundleMcpPath = path.resolve(
+      __dirname,
+      '../../../../bundle/bundled/chrome-devtools-mcp.mjs',
+    );
+    const finalThirdPartyPath = path.resolve(
+      __dirname,
+      '../../../../bundle/bundled/third_party/index.js',
+    );
+
+    if (fs.existsSync(finalBundleMcpPath)) {
+      const content = fs.readFileSync(finalBundleMcpPath, 'utf8');
+      expect(content).not.toContain(LEAKED_KEY);
+    }
+
+    if (fs.existsSync(finalThirdPartyPath)) {
+      const content = fs.readFileSync(finalThirdPartyPath, 'utf8');
+      expect(content).not.toContain(LEAKED_KEY);
+    }
+  });
+});