From 5f6376a38ad261e1b456bf6a5c7f9e7ba8ec8272 Mon Sep 17 00:00:00 2001 From: ibotdotout Date: Sun, 22 Oct 2017 17:35:13 +0700 Subject: [PATCH 1/6] test(text-helper): add test for emojifyText, abbreviateNumber --- __tests__/tests/utilities/text-helper.js | 34 ++++++++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 __tests__/tests/utilities/text-helper.js diff --git a/__tests__/tests/utilities/text-helper.js b/__tests__/tests/utilities/text-helper.js new file mode 100644 index 000000000..d74c6c7bf --- /dev/null +++ b/__tests__/tests/utilities/text-helper.js @@ -0,0 +1,34 @@ +import { emojifyText, abbreviateNumber } from 'utils'; + +describe('Text Helper', () => { + describe('emojifyText', () => { + it('should get correctly display :caffee: with emoji', () => { + expected = 'I need more ☕️'; + result = emojifyText('I need more :coffee:'); + expect(result).toEqual(expected); + }); + }); + + describe('abbreviateNumber', () => { + it('should get 1 when give 1', () => { + input = 1; + expected = 1; + result = abbreviateNumber(input); + expect(result).toEqual(expected); + }); + + it('should get 1k when give 1000', () => { + input = 1000; + expected = '1k'; + result = abbreviateNumber(input); + expect(result).toEqual(expected); + }); + + it('should get 1.1k when give 1100', () => { + input = 1100; + expected = '1.1k'; + result = abbreviateNumber(input); + expect(result).toEqual(expected); + }); + }); +}); From c54a9cceca304c324c2aadd01e7a9c8aab1d3856 Mon Sep 17 00:00:00 2001 From: botbotbot Date: Tue, 24 Oct 2017 09:54:39 +0700 Subject: [PATCH 2/6] test(text-helper): improve it - mock emojifyText instead direct test output - insert const for variables - add huge and random 96234 -> 96.2k --- __tests__/tests/utilities/text-helper.js | 36 +++++++++++++++--------- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/__tests__/tests/utilities/text-helper.js b/__tests__/tests/utilities/text-helper.js index d74c6c7bf..d30f636d4 100644 --- a/__tests__/tests/utilities/text-helper.js +++ b/__tests__/tests/utilities/text-helper.js @@ -1,33 +1,43 @@ import { emojifyText, abbreviateNumber } from 'utils'; +import sinon from 'sinon'; +import emoji from 'node-emoji'; describe('Text Helper', () => { describe('emojifyText', () => { - it('should get correctly display :caffee: with emoji', () => { - expected = 'I need more ☕️'; - result = emojifyText('I need more :coffee:'); - expect(result).toEqual(expected); + it('should call correcly with text params', () => { + const emojify = sinon.spy(emoji, 'emojify'); + const input = 'I need more :coffee'; + emojifyText(input); + expect(emojify.calledWith(input)).toEqual(true); }); }); describe('abbreviateNumber', () => { it('should get 1 when give 1', () => { - input = 1; - expected = 1; - result = abbreviateNumber(input); + const input = 1; + const expected = 1; + const result = abbreviateNumber(input); expect(result).toEqual(expected); }); it('should get 1k when give 1000', () => { - input = 1000; - expected = '1k'; - result = abbreviateNumber(input); + const input = 1000; + const expected = '1k'; + const result = abbreviateNumber(input); expect(result).toEqual(expected); }); it('should get 1.1k when give 1100', () => { - input = 1100; - expected = '1.1k'; - result = abbreviateNumber(input); + const input = 1100; + const expected = '1.1k'; + const result = abbreviateNumber(input); + expect(result).toEqual(expected); + }); + + it('should get 96.2k when give 96234', () => { + const input = 96234; + const expected = '96.2k'; + const result = abbreviateNumber(input); expect(result).toEqual(expected); }); }); From 0a4ef4190a05cdb1abe2f1438b2026f54f4299d2 Mon Sep 17 00:00:00 2001 From: ibotdotout Date: Tue, 24 Oct 2017 19:26:44 +0700 Subject: [PATCH 3/6] test(text-helper): add new line before expect --- __tests__/tests/utilities/text-helper.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/__tests__/tests/utilities/text-helper.js b/__tests__/tests/utilities/text-helper.js index d30f636d4..97925cdc6 100644 --- a/__tests__/tests/utilities/text-helper.js +++ b/__tests__/tests/utilities/text-helper.js @@ -8,6 +8,7 @@ describe('Text Helper', () => { const emojify = sinon.spy(emoji, 'emojify'); const input = 'I need more :coffee'; emojifyText(input); + expect(emojify.calledWith(input)).toEqual(true); }); }); @@ -17,6 +18,7 @@ describe('Text Helper', () => { const input = 1; const expected = 1; const result = abbreviateNumber(input); + expect(result).toEqual(expected); }); @@ -24,6 +26,7 @@ describe('Text Helper', () => { const input = 1000; const expected = '1k'; const result = abbreviateNumber(input); + expect(result).toEqual(expected); }); @@ -31,6 +34,7 @@ describe('Text Helper', () => { const input = 1100; const expected = '1.1k'; const result = abbreviateNumber(input); + expect(result).toEqual(expected); }); @@ -38,6 +42,7 @@ describe('Text Helper', () => { const input = 96234; const expected = '96.2k'; const result = abbreviateNumber(input); + expect(result).toEqual(expected); }); }); From c7af126444d48af277ac4e59ccf5529296bfed88 Mon Sep 17 00:00:00 2001 From: ibotdotout Date: Tue, 24 Oct 2017 19:41:44 +0700 Subject: [PATCH 4/6] test(text-helper): add new line after variables --- __tests__/tests/utilities/text-helper.js | 1 + 1 file changed, 1 insertion(+) diff --git a/__tests__/tests/utilities/text-helper.js b/__tests__/tests/utilities/text-helper.js index 97925cdc6..eb4b4dc36 100644 --- a/__tests__/tests/utilities/text-helper.js +++ b/__tests__/tests/utilities/text-helper.js @@ -7,6 +7,7 @@ describe('Text Helper', () => { it('should call correcly with text params', () => { const emojify = sinon.spy(emoji, 'emojify'); const input = 'I need more :coffee'; + emojifyText(input); expect(emojify.calledWith(input)).toEqual(true); From 90467eaff3fe9ed5197ec9072b8516a0b8ed399b Mon Sep 17 00:00:00 2001 From: ibotdotout Date: Tue, 24 Oct 2017 19:53:38 +0700 Subject: [PATCH 5/6] test(text-helper): remove sinon -> jest for mock --- __tests__/tests/utilities/text-helper.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/__tests__/tests/utilities/text-helper.js b/__tests__/tests/utilities/text-helper.js index eb4b4dc36..2651f3f15 100644 --- a/__tests__/tests/utilities/text-helper.js +++ b/__tests__/tests/utilities/text-helper.js @@ -1,16 +1,18 @@ import { emojifyText, abbreviateNumber } from 'utils'; -import sinon from 'sinon'; import emoji from 'node-emoji'; describe('Text Helper', () => { describe('emojifyText', () => { it('should call correcly with text params', () => { - const emojify = sinon.spy(emoji, 'emojify'); + const emojify = jest.spyOn(emoji, 'emojify'); const input = 'I need more :coffee'; emojifyText(input); - expect(emojify.calledWith(input)).toEqual(true); + expect(emojify).toBeCalledWith(input); + + emojify.mockReset(); + emojify.mockRestore(); }); }); From fd2b6a6b4dae1fd059932e0dcb1df4f611e76e9d Mon Sep 17 00:00:00 2001 From: botbotbot Date: Wed, 25 Oct 2017 09:35:05 +0700 Subject: [PATCH 6/6] test(text-helper): clean test case title --- __tests__/tests/utilities/text-helper.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/__tests__/tests/utilities/text-helper.js b/__tests__/tests/utilities/text-helper.js index 2651f3f15..89f5110cc 100644 --- a/__tests__/tests/utilities/text-helper.js +++ b/__tests__/tests/utilities/text-helper.js @@ -17,7 +17,7 @@ describe('Text Helper', () => { }); describe('abbreviateNumber', () => { - it('should get 1 when give 1', () => { + it('should return 1 when given 1', () => { const input = 1; const expected = 1; const result = abbreviateNumber(input); @@ -25,7 +25,7 @@ describe('Text Helper', () => { expect(result).toEqual(expected); }); - it('should get 1k when give 1000', () => { + it('should return 1k when given 1000', () => { const input = 1000; const expected = '1k'; const result = abbreviateNumber(input); @@ -33,7 +33,7 @@ describe('Text Helper', () => { expect(result).toEqual(expected); }); - it('should get 1.1k when give 1100', () => { + it('should return 1.1k when given 1100', () => { const input = 1100; const expected = '1.1k'; const result = abbreviateNumber(input); @@ -41,7 +41,7 @@ describe('Text Helper', () => { expect(result).toEqual(expected); }); - it('should get 96.2k when give 96234', () => { + it('should return 96.2k when given 96234', () => { const input = 96234; const expected = '96.2k'; const result = abbreviateNumber(input);