diff --git a/extensions/ql-vscode/package.json b/extensions/ql-vscode/package.json index c35594c8135..e343266f760 100644 --- a/extensions/ql-vscode/package.json +++ b/extensions/ql-vscode/package.json @@ -82,7 +82,7 @@ "title": "CodeQL", "properties": { "codeQL.cli.executablePath": { - "scope": "window", + "scope": "machine", "type": "string", "default": "", "description": "Path to the CodeQL executable that should be used by the CodeQL extension. The executable is named `codeql` on Linux/Mac and `codeql.cmd` on Windows. This overrides all other CodeQL CLI settings." diff --git a/extensions/ql-vscode/src/config.ts b/extensions/ql-vscode/src/config.ts index d8e9d645081..ed7fbc2bd08 100644 --- a/extensions/ql-vscode/src/config.ts +++ b/extensions/ql-vscode/src/config.ts @@ -37,18 +37,16 @@ const DISTRIBUTION_SETTING = new Setting('cli', ROOT_SETTING); const CUSTOM_CODEQL_PATH_SETTING = new Setting('executablePath', DISTRIBUTION_SETTING); const INCLUDE_PRERELEASE_SETTING = new Setting('includePrerelease', DISTRIBUTION_SETTING); const PERSONAL_ACCESS_TOKEN_SETTING = new Setting('personalAccessToken', DISTRIBUTION_SETTING); -const OWNER_NAME_SETTING = new Setting('owner', DISTRIBUTION_SETTING); -const REPOSITORY_NAME_SETTING = new Setting('repository', DISTRIBUTION_SETTING); /** When these settings change, the distribution should be updated. */ -const DISTRIBUTION_CHANGE_SETTINGS = [CUSTOM_CODEQL_PATH_SETTING, INCLUDE_PRERELEASE_SETTING, PERSONAL_ACCESS_TOKEN_SETTING, OWNER_NAME_SETTING, REPOSITORY_NAME_SETTING]; +const DISTRIBUTION_CHANGE_SETTINGS = [CUSTOM_CODEQL_PATH_SETTING, INCLUDE_PRERELEASE_SETTING, PERSONAL_ACCESS_TOKEN_SETTING]; export interface DistributionConfig { customCodeQlPath?: string; includePrerelease: boolean; personalAccessToken?: string; - ownerName: string; - repositoryName: string; + ownerName?: string; + repositoryName?: string; onDidChangeDistributionConfiguration?: Event; } @@ -114,14 +112,6 @@ export class DistributionConfigListener extends ConfigListener implements Distri return PERSONAL_ACCESS_TOKEN_SETTING.getValue() ? PERSONAL_ACCESS_TOKEN_SETTING.getValue() : undefined; } - public get ownerName(): string { - return OWNER_NAME_SETTING.getValue(); - } - - public get repositoryName(): string { - return REPOSITORY_NAME_SETTING.getValue(); - } - public get onDidChangeDistributionConfiguration(): Event { return this._onDidChangeConfiguration.event; }