Fix dubious index check

max-schaefer · web-flow · commit 9fca57b3eda6 · 2020-11-26T08:40:36.000Z
diff --git a/extensions/ql-vscode/src/databases.ts b/extensions/ql-vscode/src/databases.ts
@@ -684,7 +684,7 @@ export class DatabaseManager extends DisposableObject {
 
     // Delete folder from workspace, if it is still there
     const folderIndex = (vscode.workspace.workspaceFolders || []).findIndex(folder => item.belongsToSourceArchiveExplorerUri(folder.uri));
-    if (index >= 0) {
+    if (folderIndex >= 0) {
       logger.log(`Removing workspace folder at index ${folderIndex}`);
       vscode.workspace.updateWorkspaceFolders(folderIndex, 1);
     }

Original file line number	Diff line number	Diff line change
`@@ -684,7 +684,7 @@ export class DatabaseManager extends DisposableObject {`
`684`	`684`
`685`	`685`	`// Delete folder from workspace, if it is still there`
`686`	`686`	`const folderIndex = (vscode.workspace.workspaceFolders \|\| []).findIndex(folder => item.belongsToSourceArchiveExplorerUri(folder.uri));`
`687`		`- if (index >= 0) {`
	`687`	`+ if (folderIndex >= 0) {`
`688`	`688`	logger.log(`Removing workspace folder at index ${folderIndex}`);
`689`	`689`	`vscode.workspace.updateWorkspaceFolders(folderIndex, 1);`
`690`	`690`	`}`