Skip to content

Commit 5786a9b

Browse files
committed
Fix running build on node 18
Two problems: 1. source-map@0.7.3 does not work on node 18 2. need to set --openssl-legacy-provider because webpack is using openssl in a legacy way that was changed in node 17.
1 parent d41c63b commit 5786a9b

3 files changed

Lines changed: 46 additions & 43 deletions

File tree

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222

2323
- uses: actions/setup-node@v1
2424
with:
25-
node-version: '16.13.0'
25+
node-version: '18'
2626

2727
- name: Install dependencies
2828
working-directory: extensions/ql-vscode

extensions/ql-vscode/package-lock.json

Lines changed: 39 additions & 37 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

extensions/ql-vscode/package.json

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1115,13 +1115,13 @@
11151115
]
11161116
},
11171117
"scripts": {
1118-
"build": "gulp",
1118+
"build": "NODE_OPTIONS=--openssl-legacy-provider gulp",
11191119
"watch": "npm-run-all -p watch:*",
1120-
"watch:extension": "tsc --watch",
1121-
"watch:webpack": "gulp watchView",
1122-
"watch:css": "gulp watchCss",
1120+
"watch:extension": "NODE_OPTIONS=--openssl-legacy-provider tsc --watch",
1121+
"watch:webpack": "NODE_OPTIONS=--openssl-legacy-provider gulp watchView",
1122+
"watch:css": "NODE_OPTIONS=--openssl-legacy-provider gulp watchCss",
11231123
"test": "mocha --exit -r ts-node/register test/pure-tests/**/*.ts",
1124-
"preintegration": "rm -rf ./out/vscode-tests && gulp",
1124+
"preintegration": "rm -rf ./out/vscode-tests && npm run build",
11251125
"integration": "node ./out/vscode-tests/run-integration-tests.js no-workspace,minimal-workspace",
11261126
"cli-integration": "npm run preintegration && node ./out/vscode-tests/run-integration-tests.js cli-integration",
11271127
"update-vscode": "node ./node_modules/vscode/bin/install",
@@ -1148,6 +1148,7 @@
11481148
"react-dom": "^17.0.2",
11491149
"semver": "~7.3.2",
11501150
"source-map-support": "^0.5.21",
1151+
"source-map": "git://github.com/mozilla/source-map.git#d69af1457a57d242e6b882ebd8aff1d145611b77",
11511152
"stream": "^0.0.2",
11521153
"stream-chain": "~2.2.4",
11531154
"stream-json": "~1.7.3",

0 commit comments

Comments
 (0)