feat: make all toolsets default so skills have full tool surface

All toolsets are now enabled by default (Default: true). This ensures
every tool is registered out of the box, which is required for skills
to work — skills handle progressive tool discovery, so the server
should expose the full surface. Users can still restrict with
--toolsets if needed.

Reverts the inv.AllTools() registration workaround from server.go
since the normal RegisterAll path now picks up everything.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: SamMorrowDrums

pkg/github/server.go

@@ -125,12 +125,6 @@ func NewMCPServer(ctx context.Context, cfg *MCPServerConfig, deps ToolDependenci
 	}
 
 	// Register skill resources for MCP clients that support skills-based discovery.
-	// When skills are present, register ALL tools from all toolsets so that skills
-	// can progressively reveal the full tool surface. The skills handle disclosure;
-	// the server exposes everything.
-	for _, tool := range inv.AllTools() {
-		tool.RegisterFunc(ghServer, deps)
-	}
 	RegisterSkillResources(ghServer)
 
 	return ghServer, nil

pkg/github/tools.go

@@ -43,6 +43,7 @@ var (
 	ToolsetMetadataGit = inventory.ToolsetMetadata{
 		ID:          "git",
 		Description: "GitHub Git API related tools for low-level Git operations",
+		Default:     true,
 		Icon:        "git-branch",
 	}
 	ToolsetMetadataIssues = inventory.ToolsetMetadata{
@@ -66,56 +67,67 @@ var (
 	ToolsetMetadataOrgs = inventory.ToolsetMetadata{
 		ID:          "orgs",
 		Description: "GitHub Organization related tools",
+		Default:     true,
 		Icon:        "organization",
 	}
 	ToolsetMetadataActions = inventory.ToolsetMetadata{
 		ID:          "actions",
 		Description: "GitHub Actions workflows and CI/CD operations",
+		Default:     true,
 		Icon:        "workflow",
 	}
 	ToolsetMetadataCodeSecurity = inventory.ToolsetMetadata{
 		ID:          "code_security",
 		Description: "Code security related tools, such as GitHub Code Scanning",
+		Default:     true,
 		Icon:        "codescan",
 	}
 	ToolsetMetadataSecretProtection = inventory.ToolsetMetadata{
 		ID:          "secret_protection",
 		Description: "Secret protection related tools, such as GitHub Secret Scanning",
+		Default:     true,
 		Icon:        "shield-lock",
 	}
 	ToolsetMetadataDependabot = inventory.ToolsetMetadata{
 		ID:          "dependabot",
 		Description: "Dependabot tools",
+		Default:     true,
 		Icon:        "dependabot",
 	}
 	ToolsetMetadataNotifications = inventory.ToolsetMetadata{
 		ID:          "notifications",
 		Description: "GitHub Notifications related tools",
+		Default:     true,
 		Icon:        "bell",
 	}
 	ToolsetMetadataDiscussions = inventory.ToolsetMetadata{
 		ID:          "discussions",
 		Description: "GitHub Discussions related tools",
+		Default:     true,
 		Icon:        "comment-discussion",
 	}
 	ToolsetMetadataGists = inventory.ToolsetMetadata{
 		ID:          "gists",
 		Description: "GitHub Gist related tools",
+		Default:     true,
 		Icon:        "logo-gist",
 	}
 	ToolsetMetadataSecurityAdvisories = inventory.ToolsetMetadata{
 		ID:          "security_advisories",
 		Description: "Security advisories related tools",
+		Default:     true,
 		Icon:        "shield",
 	}
 	ToolsetMetadataProjects = inventory.ToolsetMetadata{
 		ID:          "projects",
 		Description: "GitHub Projects related tools",
+		Default:     true,
 		Icon:        "project",
 	}
 	ToolsetMetadataStargazers = inventory.ToolsetMetadata{
 		ID:          "stargazers",
 		Description: "GitHub Stargazers related tools",
+		Default:     true,
 		Icon:        "star",
 	}
 	ToolsetMetadataDynamic = inventory.ToolsetMetadata{
@@ -126,6 +138,7 @@ var (
 	ToolsetLabels = inventory.ToolsetMetadata{
 		ID:          "labels",
 		Description: "GitHub Labels related tools",
+		Default:     true,
 		Icon:        "tag",
 	}
 

pkg/github/tools_test.go

@@ -8,6 +8,28 @@ import (
 )
 
 func TestAddDefaultToolset(t *testing.T) {
+	allDefaultToolsets := []string{
+		"actions",
+		"code_security",
+		"context",
+		"copilot",
+		"dependabot",
+		"discussions",
+		"gists",
+		"git",
+		"issues",
+		"labels",
+		"notifications",
+		"orgs",
+		"projects",
+		"pull_requests",
+		"repos",
+		"secret_protection",
+		"security_advisories",
+		"stargazers",
+		"users",
+	}
+
 	tests := []struct {
 		name     string
 		input    []string
@@ -19,42 +41,19 @@ func TestAddDefaultToolset(t *testing.T) {
 			expected: []string{"actions", "gists"},
 		},
 		{
-			name:  "default keyword present - expand and remove default",
-			input: []string{"default"},
-			expected: []string{
-				"context",
-				"copilot",
-				"repos",
-				"issues",
-				"pull_requests",
-				"users",
-			},
+			name:     "default keyword present - expand and remove default",
+			input:    []string{"default"},
+			expected: allDefaultToolsets,
 		},
 		{
-			name:  "default with additional toolsets",
-			input: []string{"default", "actions", "gists"},
-			expected: []string{
-				"actions",
-				"gists",
-				"context",
-				"copilot",
-				"repos",
-				"issues",
-				"pull_requests",
-				"users",
-			},
+			name:     "default with additional toolsets",
+			input:    []string{"default", "actions", "gists"},
+			expected: allDefaultToolsets,
 		},
 		{
-			name:  "default with overlapping toolsets - should not duplicate",
-			input: []string{"default", "context", "repos"},
-			expected: []string{
-				"context",
-				"copilot",
-				"repos",
-				"issues",
-				"pull_requests",
-				"users",
-			},
+			name:     "default with overlapping toolsets - should not duplicate",
+			input:    []string{"default", "context", "repos"},
+			expected: allDefaultToolsets,
 		},
 		{
 			name:     "empty input",