Skip to content

Commit 934fb86

Browse files
edoardopirovanoEdoardo Pirovano
authored andcommitted
Address PR comments from @robertbrignull
1 parent e145aa4 commit 934fb86

5 files changed

Lines changed: 11 additions & 14 deletions

File tree

.github/workflows/pr-checks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
run: .github/workflows/script/check-js.sh
2828

2929
check-node-modules:
30-
runs-on: ubuntu-latest
30+
runs-on: macos-latest
3131

3232
steps:
3333
- uses: actions/checkout@v2

.github/workflows/script/check-node-modules.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ if [ ! -z "$(git status --porcelain)" ]; then
77
>&2 echo "Failed: Repo should be clean before testing!"
88
exit 1
99
fi
10+
sudo npm install --force -g npm@latest
1011
# Reinstall modules and then clean to remove absolute paths
1112
# Use 'npm ci' instead of 'npm install' as this is intended to be reproducible
1213
npm ci

.github/workflows/update-dependencies.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
name: Update dependencies
22
on:
3-
pull_request:
3+
pull_request_target:
4+
types: [opened, synchronize, reopened, labeled]
45

56
jobs:
67
update:
@@ -32,6 +33,9 @@ jobs:
3233
git config --global user.email "github-actions@github.com"
3334
git config --global user.name "github-actions[bot]"
3435
git add node_modules
35-
git commit -am "Update checked-in dependencies"
36-
git push
36+
if ! git commit -am "Update checked-in dependencies" ; then
37+
echo "No changes detected, skipping pushing..."
38+
exit 0
39+
fi
40+
git push origin "$BRANCH"
3741

node_modules/.package-lock.json

Lines changed: 1 addition & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock.json

Lines changed: 1 addition & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)