Skip to content

Commit b5a9fd5

Browse files
gmackallgilnobrega
authored andcommitted
Remove additional references to engine v1 android embedding (flutter#146523)
flutter-team-archive/engine#51229 blocked [the roll](flutter#146522) and had to be reverted, which is a shame, but on the bright side it made it possible to point the framework at my removal pr, at the point of its merging the first time This fixes all errors that are fixable in the framework that would have blocked the roll. There are some that aren't fixable here (they need to be fixed in the engine)*, so I'll fix those in the engine but unfortunately I can't pick up another version here to re-test until I try to roll again � *This category is: uses of plugins that in turn have a `registerWith`, that references the v1 embedding. The plan to fix these cases is to leave the interface that that method relies on around for now. See flutter/packages#6494 (comment) for details
1 parent 529dd63 commit b5a9fd5

2 files changed

Lines changed: 1 addition & 6 deletions

File tree

dev/tools/create_api_docs.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ const Map<String, PlatformDocsSection> kPlatformDocs = <String, PlatformDocsSect
4040
'android': PlatformDocsSection(
4141
zipName: 'android-javadoc.zip',
4242
sectionName: 'Android',
43-
checkFile: 'io/flutter/view/FlutterView.html',
43+
checkFile: 'io/flutter/embedding/android/FlutterView.html',
4444
subdir: 'javadoc',
4545
),
4646
'ios': PlatformDocsSection(

packages/integration_test/android/src/main/java/dev/flutter/plugins/integration_test/IntegrationTestPlugin.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,6 @@ public class IntegrationTestPlugin implements MethodCallHandler, FlutterPlugin,
3030
public static final Future<Map<String, String>> testResults = testResultsSettable;
3131

3232
/** Plugin registration. */
33-
@SuppressWarnings("deprecation")
34-
public static void registerWith(io.flutter.plugin.common.PluginRegistry.Registrar registrar) {
35-
final IntegrationTestPlugin instance = new IntegrationTestPlugin();
36-
instance.onAttachedToEngine(registrar.context(), registrar.messenger());
37-
}
3833

3934
@Override
4035
public void onAttachedToEngine(FlutterPluginBinding binding) {

0 commit comments

Comments
 (0)