Fix permissions when writing folders

A folder in Zip always have the DOS attribute set and, shifted by 16
bits, there may be the UNIX flags made of the rights (including the
executable bit to cross the folder) and the inode type.

Author: lephilousophe

lib/core/zip-writer.js

@@ -251,10 +251,9 @@ async function addFile(zipWriter, name, reader, options) {
 			name += DIRECTORY_SIGNATURE;
 		}
 		if (externalFileAttributes === 0) {
-			if (msDosCompatible) {
-				externalFileAttributes = FILE_ATTR_MSDOS_DIR_MASK;
-			} else {
-				externalFileAttributes = FILE_ATTR_UNIX_TYPE_DIR << 16;
+			externalFileAttributes = FILE_ATTR_MSDOS_DIR_MASK;
+			if (!msDosCompatible) {
+				externalFileAttributes |= (FILE_ATTR_UNIX_TYPE_DIR | FILE_ATTR_UNIX_EXECUTABLE_MASK | FILE_ATTR_UNIX_DEFAULT_MASK) << 16;
 			}
 		}
 	} else if (!msDosCompatible && externalFileAttributes === 0) {

tests/all/test-directory.js

@@ -18,7 +18,9 @@ async function test() {
 	await zipWriter.close();
 	const zipReader = new zip.ZipReader(new zip.BlobReader(await blobWriter.getData()));
 	const entries = await zipReader.getEntries();
-	if (entries[0].directory && entries[0].filename == FOLDER_NAME) {
+	if (entries[0].directory && entries[0].filename == FOLDER_NAME &&
+		(entries[0].externalFileAttributes & 0xffff) == 0x10 &&
+		entries[0].externalFileAttributes >> 16 == 0o40755) {
 		if (!entries[1].directory && entries[1].filename == FILENAME) {
 			const text = await entries[1].getData(new zip.TextWriter());
 			await zipReader.close();