fix: query DOM element without role for cross-platform compatibility - #237
Merged
Conversation
- I was a little bit surprised about this but on certain platform (mainly Salesforce in my case), the `role` attributes are completely stripped. So the DOM query I had for arrow highlight navigation wasn't working in Salesforce. So removing `[role]` query selector but adding another type of attribute to keep query still focused with `li[datakey]` is enough to get it working in Salesforce
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
roleattributes might completely stripped out of the final DOM template. So the DOM query I was using for arrow highlight navigation wasn't working at all in Salesforce. So removing[role]from the query selector is enough to get it working, however I'll addli[datakey]to get it working in Salesforce but still keep it focused to our expected list of elements to query for the arrow navigation to work