Skip to content

Commit ad17d6f

Browse files
committed
Rename HelloCardboardApp to CardboardPlusPlusApp
This change updates the application class name, macro definitions, and header guards from "HelloCardboard" branding to "CardboardPlusPlus" across the JNI and C++ source files.
1 parent 9547c61 commit ad17d6f

5 files changed

Lines changed: 51 additions & 51 deletions

File tree

cardboardplusplus-android/src/main/jni/cardboardplusplus_app.cc

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ constexpr const char* kTexFragmentShader =
104104

105105
} // anonymous namespace
106106

107-
HelloCardboardApp::HelloCardboardApp(JavaVM* vm, jobject obj,
107+
CardboardPlusPlusApp::CardboardPlusPlusApp(JavaVM* vm, jobject obj,
108108
jobject asset_mgr_obj)
109109
: head_tracker_(nullptr),
110110
lens_distortion_(nullptr),
@@ -143,14 +143,14 @@ HelloCardboardApp::HelloCardboardApp(JavaVM* vm, jobject obj,
143143
LOGD("Network client started");
144144
}
145145

146-
HelloCardboardApp::~HelloCardboardApp() {
146+
CardboardPlusPlusApp::~CardboardPlusPlusApp() {
147147
networkClient_.Stop();
148148
CardboardHeadTracker_destroy(head_tracker_);
149149
CardboardLensDistortion_destroy(lens_distortion_);
150150
CardboardDistortionRenderer_destroy(distortion_renderer_);
151151
}
152152

153-
void HelloCardboardApp::OnSurfaceCreated(JNIEnv* env) {
153+
void CardboardPlusPlusApp::OnSurfaceCreated(JNIEnv* env) {
154154
const int obj_vertex_shader =
155155
LoadGLShader(GL_VERTEX_SHADER, kObjVertexShader);
156156
const int obj_fragment_shader =
@@ -187,30 +187,30 @@ void HelloCardboardApp::OnSurfaceCreated(JNIEnv* env) {
187187

188188
CHECKGLERROR("Tex program params");
189189

190-
HELLOCARDBOARD_CHECK(quad_.Initialize(tex_position_param_, tex_tex_coord_param_,
190+
CARDBOARDPLUSPLUS_CHECK(quad_.Initialize(tex_position_param_, tex_tex_coord_param_,
191191
"Quad.obj", asset_mgr_));
192192

193-
HELLOCARDBOARD_CHECK(room_.Initialize(obj_position_param_, obj_uv_param_,
193+
CARDBOARDPLUSPLUS_CHECK(room_.Initialize(obj_position_param_, obj_uv_param_,
194194
"CubeRoom.obj", asset_mgr_));
195-
HELLOCARDBOARD_CHECK(
195+
CARDBOARDPLUSPLUS_CHECK(
196196
room_tex_.Initialize(env, java_asset_mgr_, "CubeRoom_BakedDiffuse.png"));
197-
HELLOCARDBOARD_CHECK(target_object_meshes_[0].Initialize(
197+
CARDBOARDPLUSPLUS_CHECK(target_object_meshes_[0].Initialize(
198198
obj_position_param_, obj_uv_param_, "Icosahedron.obj", asset_mgr_));
199-
HELLOCARDBOARD_CHECK(target_object_not_selected_textures_[0].Initialize(
199+
CARDBOARDPLUSPLUS_CHECK(target_object_not_selected_textures_[0].Initialize(
200200
env, java_asset_mgr_, "Icosahedron_Blue_BakedDiffuse.png"));
201-
HELLOCARDBOARD_CHECK(target_object_selected_textures_[0].Initialize(
201+
CARDBOARDPLUSPLUS_CHECK(target_object_selected_textures_[0].Initialize(
202202
env, java_asset_mgr_, "Icosahedron_Pink_BakedDiffuse.png"));
203-
HELLOCARDBOARD_CHECK(target_object_meshes_[1].Initialize(
203+
CARDBOARDPLUSPLUS_CHECK(target_object_meshes_[1].Initialize(
204204
obj_position_param_, obj_uv_param_, "QuadSphere.obj", asset_mgr_));
205-
HELLOCARDBOARD_CHECK(target_object_not_selected_textures_[1].Initialize(
205+
CARDBOARDPLUSPLUS_CHECK(target_object_not_selected_textures_[1].Initialize(
206206
env, java_asset_mgr_, "QuadSphere_Blue_BakedDiffuse.png"));
207-
HELLOCARDBOARD_CHECK(target_object_selected_textures_[1].Initialize(
207+
CARDBOARDPLUSPLUS_CHECK(target_object_selected_textures_[1].Initialize(
208208
env, java_asset_mgr_, "QuadSphere_Pink_BakedDiffuse.png"));
209-
HELLOCARDBOARD_CHECK(target_object_meshes_[2].Initialize(
209+
CARDBOARDPLUSPLUS_CHECK(target_object_meshes_[2].Initialize(
210210
obj_position_param_, obj_uv_param_, "TriSphere.obj", asset_mgr_));
211-
HELLOCARDBOARD_CHECK(target_object_not_selected_textures_[2].Initialize(
211+
CARDBOARDPLUSPLUS_CHECK(target_object_not_selected_textures_[2].Initialize(
212212
env, java_asset_mgr_, "TriSphere_Blue_BakedDiffuse.png"));
213-
HELLOCARDBOARD_CHECK(target_object_selected_textures_[2].Initialize(
213+
CARDBOARDPLUSPLUS_CHECK(target_object_selected_textures_[2].Initialize(
214214
env, java_asset_mgr_, "TriSphere_Pink_BakedDiffuse.png"));
215215

216216
// Target object first appears directly in front of user.
@@ -219,13 +219,13 @@ void HelloCardboardApp::OnSurfaceCreated(JNIEnv* env) {
219219
CHECKGLERROR("OnSurfaceCreated");
220220
}
221221

222-
void HelloCardboardApp::SetScreenParams(int width, int height) {
222+
void CardboardPlusPlusApp::SetScreenParams(int width, int height) {
223223
screen_width_ = width;
224224
screen_height_ = height;
225225
screen_params_changed_ = true;
226226
}
227227

228-
void HelloCardboardApp::OnDrawFrame() {
228+
void CardboardPlusPlusApp::OnDrawFrame() {
229229
if (!UpdateDeviceParams()) {
230230
return;
231231
}
@@ -286,19 +286,19 @@ void HelloCardboardApp::OnDrawFrame() {
286286
CHECKGLERROR("onDrawFrame");
287287
}
288288

289-
void HelloCardboardApp::OnTriggerEvent() {
289+
void CardboardPlusPlusApp::OnTriggerEvent() {
290290
if (IsPointingAtTarget()) {
291291
HideTarget();
292292
}
293293
show_camera_texture_ = !show_camera_texture_;
294294
}
295295

296-
void HelloCardboardApp::OnPause() {
296+
void CardboardPlusPlusApp::OnPause() {
297297
CardboardHeadTracker_pause(head_tracker_);
298298
networkClient_.Stop();
299299
}
300300

301-
void HelloCardboardApp::OnResume() {
301+
void CardboardPlusPlusApp::OnResume() {
302302
CardboardHeadTracker_resume(head_tracker_);
303303

304304
// Restart network client
@@ -318,11 +318,11 @@ void HelloCardboardApp::OnResume() {
318318
CardboardQrCode_destroy(buffer);
319319
}
320320

321-
void HelloCardboardApp::SwitchViewer() {
321+
void CardboardPlusPlusApp::SwitchViewer() {
322322
CardboardQrCode_scanQrCodeAndSaveDeviceParams();
323323
}
324324

325-
bool HelloCardboardApp::UpdateDeviceParams() {
325+
bool CardboardPlusPlusApp::UpdateDeviceParams() {
326326
// Checks if screen or device parameters changed
327327
if (!screen_params_changed_ && !device_params_changed_) {
328328
return true;
@@ -379,7 +379,7 @@ bool HelloCardboardApp::UpdateDeviceParams() {
379379
return true;
380380
}
381381

382-
void HelloCardboardApp::GlSetup() {
382+
void CardboardPlusPlusApp::GlSetup() {
383383
LOGD("GL SETUP");
384384

385385
if (framebuffer_ != 0) {
@@ -446,7 +446,7 @@ void HelloCardboardApp::GlSetup() {
446446
CHECKGLERROR("GlSetup");
447447
}
448448

449-
void HelloCardboardApp::GlTeardown() {
449+
void CardboardPlusPlusApp::GlTeardown() {
450450
if (framebuffer_ == 0) {
451451
return;
452452
}
@@ -468,7 +468,7 @@ void HelloCardboardApp::GlTeardown() {
468468
CHECKGLERROR("GlTeardown");
469469
}
470470

471-
Matrix4x4 HelloCardboardApp::GetPose() {
471+
Matrix4x4 CardboardPlusPlusApp::GetPose() {
472472
std::array<float, 4> out_orientation;
473473
std::array<float, 3> out_position;
474474
CardboardHeadTracker_getPose(
@@ -494,12 +494,12 @@ Matrix4x4 HelloCardboardApp::GetPose() {
494494
Quatf::FromXYZW(&out_orientation[0]).ToMatrix();
495495
}
496496

497-
void HelloCardboardApp::DrawWorld() {
497+
void CardboardPlusPlusApp::DrawWorld() {
498498
DrawRoom();
499499
DrawTarget();
500500
}
501501

502-
void HelloCardboardApp::DrawTarget() {
502+
void CardboardPlusPlusApp::DrawTarget() {
503503
glUseProgram(obj_program_);
504504

505505
std::array<float, 16> target_array = modelview_projection_target_.ToGlArray();
@@ -516,7 +516,7 @@ void HelloCardboardApp::DrawTarget() {
516516
CHECKGLERROR("DrawTarget");
517517
}
518518

519-
void HelloCardboardApp::DrawRoom() {
519+
void CardboardPlusPlusApp::DrawRoom() {
520520
glUseProgram(obj_program_);
521521

522522
std::array<float, 16> room_array = modelview_projection_room_.ToGlArray();
@@ -529,7 +529,7 @@ void HelloCardboardApp::DrawRoom() {
529529
CHECKGLERROR("DrawRoom");
530530
}
531531

532-
void HelloCardboardApp::DrawTexQuad(GLuint texture_id) {
532+
void CardboardPlusPlusApp::DrawTexQuad(GLuint texture_id) {
533533
glUseProgram(tex_program_);
534534

535535
Matrix4x4 identity = GetIdentityMatrix();
@@ -545,7 +545,7 @@ void HelloCardboardApp::DrawTexQuad(GLuint texture_id) {
545545
CHECKGLERROR("DrawTexQuad");
546546
}
547547

548-
void HelloCardboardApp::HideTarget() {
548+
void CardboardPlusPlusApp::HideTarget() {
549549
cur_target_object_ = RandomUniformInt(kTargetMeshCount);
550550

551551
float angle = RandomUniformFloat(-M_PI, M_PI);
@@ -557,7 +557,7 @@ void HelloCardboardApp::HideTarget() {
557557
model_target_ = GetTranslationMatrix(target_position);
558558
}
559559

560-
void HelloCardboardApp::DrawCameraQuad(GLuint texture_id) {
560+
void CardboardPlusPlusApp::DrawCameraQuad(GLuint texture_id) {
561561
glUseProgram(tex_program_);
562562

563563
Matrix4x4 identity = GetIdentityMatrix();
@@ -573,7 +573,7 @@ void HelloCardboardApp::DrawCameraQuad(GLuint texture_id) {
573573
CHECKGLERROR("DrawCameraQuad");
574574
}
575575

576-
bool HelloCardboardApp::IsPointingAtTarget() {
576+
bool CardboardPlusPlusApp::IsPointingAtTarget() {
577577
// Compute vectors pointing towards the reticle and towards the target object
578578
// in head space.
579579
Matrix4x4 head_from_target = head_view_ * model_target_;
@@ -586,15 +586,15 @@ bool HelloCardboardApp::IsPointingAtTarget() {
586586
return angle < kAngleLimit;
587587
}
588588

589-
void HelloCardboardApp::OnCameraTextureInitialized(int textureId, int width, int height) {
589+
void CardboardPlusPlusApp::OnCameraTextureInitialized(int textureId, int width, int height) {
590590
camera_texture_ = static_cast<GLuint>(textureId);
591591
camera_width_ = width;
592592
camera_height_ = height;
593593
camera_texture_initialized_ = true;
594594
LOGD("Camera texture initialized: id=%d, size=%dx%d", textureId, width, height);
595595
}
596596

597-
int HelloCardboardApp::CreateCameraTexture() {
597+
int CardboardPlusPlusApp::CreateCameraTexture() {
598598
GLuint textureId = 0;
599599
glGenTextures(1, &textureId);
600600
glBindTexture(GL_TEXTURE_EXTERNAL_OES, textureId);
@@ -606,7 +606,7 @@ int HelloCardboardApp::CreateCameraTexture() {
606606
return static_cast<int>(textureId);
607607
}
608608

609-
void HelloCardboardApp::ResetCameraTexture() {
609+
void CardboardPlusPlusApp::ResetCameraTexture() {
610610
camera_texture_initialized_ = false;
611611
LOGD("Camera texture reset for pause");
612612
}

cardboardplusplus-android/src/main/jni/cardboardplusplus_app.h

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
* limitations under the License.
1515
*/
1616

17-
#ifndef HELLO_CARDBOARD_ANDROID_SRC_MAIN_JNI_HELLO_CARDBOARD_APP_H_
18-
#define HELLO_CARDBOARD_ANDROID_SRC_MAIN_JNI_HELLO_CARDBOARD_APP_H_
17+
#ifndef CARDBOARD_PLUS_PLUS_ANDROID_SRC_MAIN_JNI_CARDBOARD_PLUS_PLUS_APP_H_
18+
#define CARDBOARD_PLUS_PLUS_ANDROID_SRC_MAIN_JNI_CARDBOARD_PLUS_PLUS_APP_H_
1919

2020
#include <android/asset_manager.h>
2121
#include <jni.h>
@@ -36,18 +36,18 @@ namespace ndk_cardboardplusplus {
3636
* This is a sample app for the Cardboard SDK. It loads a simple environment and
3737
* objects that you can click on.
3838
*/
39-
class HelloCardboardApp {
39+
class CardboardPlusPlusApp {
4040
public:
4141
/**
42-
* Creates a HelloCardboardApp.
42+
* Creates a CardboardPlusPlusApp.
4343
*
4444
* @param vm JavaVM pointer.
4545
* @param obj Android activity object.
4646
* @param asset_mgr_obj The asset manager object.
4747
*/
48-
HelloCardboardApp(JavaVM* vm, jobject obj, jobject asset_mgr_obj);
48+
CardboardPlusPlusApp(JavaVM* vm, jobject obj, jobject asset_mgr_obj);
4949

50-
~HelloCardboardApp();
50+
~CardboardPlusPlusApp();
5151

5252
/**
5353
* Initializes any GL-related objects. This should be called on the rendering
@@ -230,4 +230,4 @@ class HelloCardboardApp {
230230

231231
} // namespace ndk_cardboardplusplus
232232

233-
#endif // HELLO_CARDBOARD_ANDROID_SRC_MAIN_JNI_HELLO_CARDBOARD_APP_H_
233+
#endif // CARDBOARD_PLUS_PLUS_ANDROID_SRC_MAIN_JNI_CARDBOARD_PLUS_PLUS_APP_H_

cardboardplusplus-android/src/main/jni/cardboardplusplus_jni.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,12 @@
2727

2828
namespace {
2929

30-
inline jlong jptr(ndk_cardboardplusplus::HelloCardboardApp* native_app) {
30+
inline jlong jptr(ndk_cardboardplusplus::CardboardPlusPlusApp* native_app) {
3131
return reinterpret_cast<intptr_t>(native_app);
3232
}
3333

34-
inline ndk_cardboardplusplus::HelloCardboardApp* native(jlong ptr) {
35-
return reinterpret_cast<ndk_cardboardplusplus::HelloCardboardApp*>(ptr);
34+
inline ndk_cardboardplusplus::CardboardPlusPlusApp* native(jlong ptr) {
35+
return reinterpret_cast<ndk_cardboardplusplus::CardboardPlusPlusApp*>(ptr);
3636
}
3737

3838
JavaVM* javaVm;
@@ -48,7 +48,7 @@ JNIEXPORT jint JNI_OnLoad(JavaVM* vm, void* /*reserved*/) {
4848

4949
JNI_METHOD(jlong, nativeOnCreate)
5050
(JNIEnv* /*env*/, jobject obj, jobject asset_mgr) {
51-
return jptr(new ndk_cardboardplusplus::HelloCardboardApp(javaVm, obj, asset_mgr));
51+
return jptr(new ndk_cardboardplusplus::CardboardPlusPlusApp(javaVm, obj, asset_mgr));
5252
}
5353

5454
JNI_METHOD(void, nativeOnDestroy)

cardboardplusplus-android/src/main/jni/util.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ bool Texture::Initialize(JNIEnv* env, jobject java_asset_mgr,
541541
}
542542

543543
void Texture::Bind() const {
544-
HELLOCARDBOARD_CHECK(texture_id_ != 0);
544+
CARDBOARDPLUSPLUS_CHECK(texture_id_ != 0);
545545
glActiveTexture(GL_TEXTURE0);
546546
glBindTexture(GL_TEXTURE_2D, texture_id_);
547547
}

cardboardplusplus-android/src/main/jni/util.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
* limitations under the License.
1515
*/
1616

17-
#ifndef HELLO_CARDBOARD_ANDROID_SRC_MAIN_JNI_UTIL_H_
18-
#define HELLO_CARDBOARD_ANDROID_SRC_MAIN_JNI_UTIL_H_
17+
#ifndef CARDBOARD_PLUS_PLUS_ANDROID_SRC_MAIN_JNI_UTIL_H_
18+
#define CARDBOARD_PLUS_PLUS_ANDROID_SRC_MAIN_JNI_UTIL_H_
1919

2020
#include <android/asset_manager.h>
2121
#include <jni.h>
@@ -29,7 +29,7 @@
2929
#define LOGW(...) __android_log_print(ANDROID_LOG_WARN, LOG_TAG, __VA_ARGS__)
3030
#define LOGD(...) __android_log_print(ANDROID_LOG_DEBUG, LOG_TAG, __VA_ARGS__)
3131
#define LOGE(...) __android_log_print(ANDROID_LOG_ERROR, LOG_TAG, __VA_ARGS__)
32-
#define HELLOCARDBOARD_CHECK(condition) \
32+
#define CARDBOARDPLUSPLUS_CHECK(condition) \
3333
if (!(condition)) { \
3434
LOGE("*** CHECK FAILED at %s:%d: %s", __FILE__, __LINE__, #condition); \
3535
abort(); \
@@ -193,4 +193,4 @@ class Texture {
193193

194194
} // namespace ndk_cardboardplusplus
195195

196-
#endif // HELLO_CARDBOARD_ANDROID_SRC_MAIN_JNI_UTIL_H_
196+
#endif // CARDBOARD_PLUS_PLUS_ANDROID_SRC_MAIN_JNI_UTIL_H_

0 commit comments

Comments
 (0)