Localize UI strings and improve model actions

Replaced hardcoded UI strings with localized resource bundle lookups in controllers and FXML. Added new keys to messages.properties and messages_es.properties for model actions, download status, and error handling. Updated button styles to use atlantafx theme constants for consistency.

Author: fredericksalazar

src/main/java/com/org/ollamafx/controller/DownloadPopupController.java

@@ -56,7 +56,7 @@ public void setDownloadTask(Task<Void> task) {
     }
 
     public void setModelName(String modelName) {
-        titleLabel.setText(com.org.ollamafx.App.getBundle().getString("download.title") + " " + modelName);
+        titleLabel.setText(com.org.ollamafx.App.getBundle().getString("download.title.default") + " " + modelName);
     }
 
     @FXML

src/main/java/com/org/ollamafx/controller/LocalModelsController.java

@@ -2,6 +2,7 @@
 
 import com.org.ollamafx.manager.ModelManager;
 import com.org.ollamafx.model.OllamaModel;
+import atlantafx.base.theme.Styles;
 import javafx.application.Platform;
 import javafx.collections.ListChangeListener;
 import javafx.fxml.FXML;
@@ -14,6 +15,9 @@
 import javafx.scene.layout.Region;
 import javafx.scene.layout.VBox;
 
+import com.org.ollamafx.App;
+import java.text.MessageFormat;
+
 import java.net.URL;
 import java.util.ResourceBundle;
 
@@ -52,7 +56,7 @@ private void populateLocalModels() {
         modelListContainer.setSpacing(12);
 
         if (modelManager == null || modelManager.getLocalModels().isEmpty()) {
-            Label placeholder = new Label("No installed models found.");
+            Label placeholder = new Label(App.getBundle().getString("local.empty"));
             placeholder.setStyle("-fx-text-fill: -color-fg-subtle; -fx-font-size: 14px;");
             modelListContainer.getChildren().add(placeholder);
             return;
@@ -92,8 +96,8 @@ private void populateLocalModels() {
             HBox.setHgrow(spacer, Priority.ALWAYS);
 
             // Delete Action (Text Button, Apple Destructive Style)
-            Button deleteBtn = new Button("Uninstall");
-            deleteBtn.getStyleClass().add("apple-button-destructive");
+            Button deleteBtn = new Button(App.getBundle().getString("model.action.uninstall"));
+            deleteBtn.getStyleClass().add(Styles.DANGER);
 
             deleteBtn.setOnAction(e -> confirmAndDelete(model));
 
@@ -105,9 +109,11 @@ private void populateLocalModels() {
     private void confirmAndDelete(OllamaModel model) {
         javafx.scene.control.Alert alert = new javafx.scene.control.Alert(
                 javafx.scene.control.Alert.AlertType.CONFIRMATION);
-        alert.setTitle("Uninstall Model");
-        alert.setHeaderText("Delete " + model.getName() + ":" + model.getTag() + "?");
-        alert.setContentText("This action cannot be undone. The model files will be removed from your system.");
+        alert.setTitle(App.getBundle().getString("local.uninstall.title"));
+        String header = MessageFormat.format(App.getBundle().getString("local.uninstall.header"),
+                model.getName() + ":" + model.getTag());
+        alert.setHeaderText(header);
+        alert.setContentText(App.getBundle().getString("local.uninstall.content"));
 
         // Apply styling to dialog if we had a Utils method for it, or just rely on
         // default for now.

src/main/java/com/org/ollamafx/controller/ModelDetailController.java

@@ -4,6 +4,7 @@
 import com.org.ollamafx.manager.ModelManager;
 import com.org.ollamafx.manager.OllamaManager;
 import com.org.ollamafx.model.OllamaModel;
+import atlantafx.base.theme.Styles;
 
 import javafx.animation.PauseTransition;
 import javafx.application.Application;
@@ -74,7 +75,7 @@ private void showDownloadPopup(OllamaModel model) {
             Stage stage = new Stage();
             stage.initModality(Modality.APPLICATION_MODAL);
             stage.initStyle(StageStyle.TRANSPARENT);
-            stage.setTitle("Downloading Model");
+            stage.setTitle(App.getBundle().getString("download.title.default"));
 
             Scene scene = new Scene(root);
             scene.setFill(Color.TRANSPARENT);
@@ -84,7 +85,7 @@ private void showDownloadPopup(OllamaModel model) {
             Task<Void> task = new Task<>() {
                 @Override
                 protected Void call() throws Exception {
-                    updateMessage("Starting download process...");
+                    updateMessage(App.getBundle().getString("download.status.process"));
                     updateProgress(0, 100);
 
                     OllamaManager.getInstance().pullModel(model.getName(), model.getTag(),
@@ -107,7 +108,7 @@ protected Void call() throws Exception {
                     String date = DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm")
                             .format(LocalDateTime.now());
                     OllamaModel newModel = new OllamaModel(
-                            model.getName(), "Installed locally", "N/A", model.getTag(),
+                            model.getName(), App.getBundle().getString("model.installed"), "N/A", model.getTag(),
                             model.sizeProperty().get(), date,
                             model.getContextLength(), model.getInputType());
                     modelManager.addLocalModel(newModel);
@@ -140,8 +141,8 @@ protected Void call() throws Exception {
 
     public void populateDetails(List<OllamaModel> modelTags) {
         if (modelTags == null || modelTags.isEmpty()) {
-            modelNameLabel.setText("Error");
-            modelDescriptionText.setText("Could not retrieve model details.");
+            modelNameLabel.setText(App.getBundle().getString("model.error"));
+            modelDescriptionText.setText(App.getBundle().getString("model.error.details"));
             modelListContainer.getChildren().clear();
             return;
         }
@@ -240,17 +241,17 @@ public void populateDetails(List<OllamaModel> modelTags) {
                     && modelManager.isModelInstalled(model.getName(), model.getTag());
 
             if (isInstalled) {
-                actionBtn.setText("Uninstall");
-                actionBtn.getStyleClass().add("apple-button-destructive");
+                actionBtn.setText(App.getBundle().getString("model.action.uninstall"));
+                actionBtn.getStyleClass().add(Styles.DANGER);
                 actionBtn.setOnAction(ev -> {
                     if (modelManager != null) {
                         modelManager.deleteModel(model.getName(), model.getTag());
                         actionBtn.setDisable(true);
                     }
                 });
             } else {
-                actionBtn.setText("Get"); // Apple Style "Get"
-                actionBtn.getStyleClass().add("apple-button-action");
+                actionBtn.setText(App.getBundle().getString("model.action.get")); // Apple Style "Get"
+                actionBtn.getStyleClass().add(Styles.SUCCESS);
                 actionBtn.setOnAction(ev -> {
                     showDownloadPopup(model);
                 });

src/main/resources/messages.properties

@@ -76,4 +76,22 @@ local.title=Installed Models
 column.name=Name
 column.tag=Tag
 column.size=Size
-column.modified=Modified
+
+# Local Models UI
+local.empty=No installed models found.
+local.uninstall.title=Uninstall Model
+local.uninstall.header=Delete {0}?
+local.uninstall.content=This action cannot be undone. The model files will be removed from your system.
+
+# Download Status
+download.status.starting=Starting...
+download.status.downloading=Downloading...
+download.status.process=Starting download process...
+
+# Model Details
+model.action.uninstall=Uninstall
+model.action.get=Get
+model.action.run=Run
+model.installed=Installed locally
+model.error=Error
+model.error.details=Could not retrieve model details

src/main/resources/messages_es.properties

@@ -76,4 +76,22 @@ local.title=Modelos Instalados
 column.name=Nombre
 column.tag=Tag
 column.size=Tamaño
-column.modified=Modificado
+
+# Local Models UI
+local.empty=No se encontraron modelos instalados.
+local.uninstall.title=Desinstalar Modelo
+local.uninstall.header=¿Eliminar {0}?
+local.uninstall.content=Esta acción no se puede deshacer. Los archivos del modelo serán eliminados de tu sistema.
+
+# Download Status
+download.status.starting=Iniciando...
+download.status.downloading=Descargando...
+download.status.process=Iniciando proceso de descarga...
+
+# Model Details
+model.action.uninstall=Desinstalar
+model.action.get=Obtener
+model.action.run=Ejecutar
+model.installed=Instalado localmente
+model.error=Error
+model.error.details=No se pudieron recuperar los detalles del modelo

src/main/resources/ui/download_popup.fxml

@@ -13,13 +13,13 @@
 
 <VBox fx:id="rootPane" alignment="CENTER" maxHeight="-Infinity" maxWidth="-Infinity" minHeight="-Infinity" minWidth="-Infinity" prefWidth="420.0" spacing="25.0" styleClass="apple-dialog" stylesheets="@../css/ollama_active.css" xmlns="http://javafx.com/javafx/21" xmlns:fx="http://javafx.com/fxml/1" fx:controller="com.org.ollamafx.controller.DownloadPopupController">
    <children>
-      <Label fx:id="titleLabel" text="Downloading..." styleClass="apple-dialog-title" wrapText="true" textAlignment="CENTER"/>
+      <Label fx:id="titleLabel" text="%download.title.default" styleClass="apple-dialog-title" wrapText="true" textAlignment="CENTER"/>
 
       <atlantafx.base.controls.RingProgressIndicator fx:id="ringIndicator" progress="0.0" prefWidth="140.0" prefHeight="140.0"/>
 
       <VBox alignment="CENTER" spacing="5.0">
          <children>
-            <Label fx:id="statusLabel" text="Starting..." styleClass="apple-dialog-status-subtle"/>
+            <Label fx:id="statusLabel" text="%download.status.starting" styleClass="apple-dialog-status-subtle"/>
          </children>
       </VBox>