fix: Fixed wrong particle position when creating a particle group - #69
Merged
Conversation
…than their parent group's position.
spydon
approved these changes
Aug 24, 2022
spydon
left a comment
spydon
left a comment
Member
There was a problem hiding this comment.
Perfect, thanks!
It would be very good with a unit test for the method, that verifies that it has the expected behavior in regards to the fixed bug, but it's not a requirement.
Collaborator
|
Thanks @gkjpettet , by any chance do you have a reference to the issue in the JBox2D library? |
Contributor
Author
|
I didn't raise an issue in their repo but the culprit is line 315 in this file. |
spydon
enabled auto-merge (squash)
October 1, 2022 12:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where particles created in
ParticleSystem.createParticleGroup()were centred around(0,0)rather than the position stipulated in the group definition. This bug is also present in the JBox2D library.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
This should not be a breaking change as it implements expected behaviour.
Related Issues
Fixes #68