feat!: Move to dart 2.17 and clean up comment. - #59
Merged
Conversation
spydon
requested review from
erickzanardo,
luanpotter,
renancaraujo and
wolfenrain
June 8, 2022 19:51
luanpotter
reviewed
Jun 9, 2022
| bool testPoint(final Vector2 p) { | ||
| return shape.testPoint(body.transform, p); | ||
| /// [point] should be in world coordinates. | ||
| bool testPoint(final Vector2 point) { |
Member
There was a problem hiding this comment.
why this one particular parameter is final and nothing else?
Member
Author
There was a problem hiding this comment.
No idea, nothing that comes from this PR though 😅
luanpotter
reviewed
Jun 9, 2022
luanpotter
reviewed
Jun 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the min version of Dart to 2.17 and updates to the newest flame_lint.
All analyze issues are fixed in this PR + removing
@paramand@returnChecklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
Related Issues