fix: use cross-spawn to avoid exec format errors when creating dataconnect apps (#10616)

* fix: use cross-spawn to avoid exec format errors when creating dataconnect apps

Replaces the native child_process spawn with cross-spawn and removes
the `shell: true` option in `src/init/features/dataconnect/create_app.ts`.
This ensures that the `dataconnect` CLI successfully executes commands
like `npm` on Windows and other OSes without encountering `ENOEXEC`
format errors.

Co-authored-by: fredzqm <9068391+fredzqm@users.noreply.github.com>

* fix: use cross-spawn to avoid exec format errors when creating dataconnect apps

Replaces the native child_process spawn with cross-spawn and removes
the `shell: true` option in `src/init/features/dataconnect/create_app.ts`.
This ensures that the `dataconnect` CLI successfully executes commands
like `npm` on Windows and other OSes without encountering `ENOEXEC`
format errors. Also updates CHANGELOG.md.

Co-authored-by: fredzqm <9068391+fredzqm@users.noreply.github.com>

* Apply suggestion from @gemini-code-assist[bot]

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* improve error logging

* Update CHANGELOG.md

* fix: resolve lint and formatting issues in dataconnect app creation

* revert: remove test-init ignores from .eslintignore and .gitignore

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Joe Hanley <joehanley@google.com>

Author: 4 people

CHANGELOG.md

@@ -1 +1,2 @@
+- Fixes `firebase init dataconnect` failing with `ENOEXEC` when creating a new template app on some operating systems. (#10616)
 - Support setting the Google Cloud Storage (GCS) test results bucket in `apptesting:execute` and `appdistribution:distribute`

src/init/features/dataconnect/create_app.ts

@@ -1,4 +1,4 @@
-import { spawn } from "child_process";
+import * as spawn from "cross-spawn";
 import * as clc from "colorette";
 import { logLabeledBullet } from "../../../utils";
 
@@ -40,8 +40,6 @@ async function executeCommand(command: string, args: string[]): Promise<void> {
     const childProcess = spawn(command, args, {
       // 'inherit' pipes stdin, stdout, and stderr to the parent process
       stdio: "inherit",
-      // Runs the command in a shell, which allows for shell syntax like pipes, etc.
-      shell: true,
     });
 
     childProcess.on("close", (code) => {
@@ -50,7 +48,7 @@ async function executeCommand(command: string, args: string[]): Promise<void> {
         resolve();
       } else {
         // Command failed
-        reject(new Error(`Command failed with exit code ${code}`));
+        reject(new Error(`Command failed with exit code ${code ?? "null"}`));
       }
     });
 

src/init/features/dataconnect/sdk.ts

@@ -19,7 +19,7 @@ import {
   SwiftSDK,
 } from "../../../dataconnect/types";
 import * as experiments from "../../../experiments";
-import { FirebaseError } from "../../../error";
+import { FirebaseError, getErrMsg, getErrStack } from "../../../error";
 import { isArray } from "lodash";
 import {
   logBullet,
@@ -100,8 +100,10 @@ export async function askQuestions(
           break;
       }
     } catch (err: unknown) {
-      // The detailed error message are already piped into stderr. No need to repeat here.
-      logLabeledError("dataconnect", `Failed to create a ${choice} app template`);
+      logLabeledError(
+        "dataconnect",
+        `Failed to create a ${choice} app template: ${getErrStack(err)}`,
+      );
     }
   }
 
@@ -279,8 +281,8 @@ async function actuateWithInfo(setup: Setup, config: Config, info: SdkRequiredIn
       configDir: connectorInfo.directory,
       account,
     });
-  } catch (e: any) {
-    logLabeledError("dataconnect", `Failed to generate SQL Connect SDKs\n${e?.message}`);
+  } catch (e: unknown) {
+    logLabeledError("dataconnect", `Failed to generate SQL Connect SDKs\n${getErrMsg(e)}`);
   }
 
   logLabeledSuccess(