Conversation
Codecov Report
@@ Coverage Diff @@
## main #932 +/- ##
==========================================
- Coverage 99.62% 99.62% -0.01%
==========================================
Files 2163 2163
Lines 241242 241264 +22
Branches 1014 1011 -3
==========================================
+ Hits 240335 240354 +19
- Misses 886 889 +3
Partials 21 21
|
|
@pkuczynski Could you go through this PR/code and reevaluate if you REALLY want to have the modules renamed not to suffixed with And then we would even have a |
I think so too, it should be named like what it does and not what generically is.
No, because fake -> helpers.fake |
64d7625 to
e45de02
Compare
e45de02 to
18a0a00
Compare
|
Would it be possible to integrate this change as a non-breaking change? Maybe with some proxy magic and deprecation of the current classes (in the constructor)? |
The classes have never been part of the API, so not sure if that is worth it. |
18a0a00 to
fac9afb
Compare
|
Team decision We will use |
closes #778