fix(generate:locale): make the definition types extendible#915
Merged
Conversation
Co-authored-by: Piotr Kuczynski <piotr.kuczynski@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #915 +/- ##
==========================================
- Coverage 99.67% 99.66% -0.02%
==========================================
Files 1957 1957
Lines 209768 209797 +29
Branches 885 885
==========================================
Hits 209084 209084
- Misses 664 693 +29
Partials 20 20
|
This was referenced May 3, 2022
Shinigami92
approved these changes
May 3, 2022
Merged
pkuczynski
reviewed
May 4, 2022
pkuczynski
approved these changes
May 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I messed up and removed code (#910), that was used by our scripts, so now I have to adjust the scripts to work without them.
We could revert that commit, but we want to get ride of it in the long run anyway.
I based this PR on #728 (#729) and adjusted the locale definitions to be
Partialby default.All usages were already partial and optional anyway:
faker/src/definitions/definitions.ts
Lines 45 to 54 in 7988464
I recommend, to review only the first commit/changes to the script and definitions as the second commit is only the execution of the script.
I will try to create a separate PR,that will check the scripts at least type wise (Issue #917).