Skip to content

fix: address.nearbyGPSCoordinate#876

Merged
Shinigami92 merged 12 commits intomainfrom
321-improve-address-nearby-gps-coordinate
Apr 27, 2022
Merged

fix: address.nearbyGPSCoordinate#876
Shinigami92 merged 12 commits intomainfrom
321-improve-address-nearby-gps-coordinate

Conversation

@Shinigami92
Copy link
Copy Markdown
Member

closes #321

@Shinigami92 Shinigami92 added c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Apr 26, 2022
@Shinigami92 Shinigami92 added this to the v6.3 - Next Minor milestone Apr 26, 2022
@Shinigami92 Shinigami92 self-assigned this Apr 26, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 26, 2022

Codecov Report

Merging #876 (1492502) into main (a64cbde) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #876      +/-   ##
==========================================
- Coverage   99.42%   99.42%   -0.01%     
==========================================
  Files        1958     1958              
  Lines      210862   210811      -51     
  Branches      907      900       -7     
==========================================
- Hits       209649   209598      -51     
  Misses       1156     1156              
  Partials       57       57              
Impacted Files Coverage Δ
src/address.ts 99.79% <100.00%> (-0.02%) ⬇️

@ST-DDT
Copy link
Copy Markdown
Member

ST-DDT commented Apr 26, 2022

It looks like the float values caused massive issues especially since we stacked the calls on those values.
With the simplified implementation we have far less error and use a much larger part of the circle.

Actual
Min: 0.00042
Avg: 0.07065
Max: 0.14406

Expected
Min: 0.00000
Avg: 0.07500
Max: 0.15000

That's 96% coverage vs the old ~0.08%

@Shinigami92 Anything you want to change/fix here?

ST-DDT
ST-DDT previously approved these changes Apr 26, 2022
Comment thread src/address.ts Outdated
Comment thread test/address.spec.ts Outdated
Comment thread test/address.spec.ts Outdated
Comment thread test/address.spec.ts Outdated
Comment thread test/address.spec.ts
Comment thread test/address.spec.ts Outdated
Comment thread test/address.spec.ts Outdated
Comment thread src/address.ts
Comment thread test/address.spec.ts Outdated
@Shinigami92 Shinigami92 marked this pull request as ready for review April 26, 2022 20:05
@Shinigami92 Shinigami92 requested a review from a team as a code owner April 26, 2022 20:05
@Shinigami92 Shinigami92 requested review from a team and ST-DDT April 26, 2022 20:05
@ST-DDT ST-DDT requested a review from a team April 26, 2022 20:38
@Shinigami92 Shinigami92 enabled auto-merge (squash) April 27, 2022 16:31
@Shinigami92 Shinigami92 merged commit 3e23fc4 into main Apr 27, 2022
@ST-DDT ST-DDT deleted the 321-improve-address-nearby-gps-coordinate branch April 27, 2022 18:41
@ST-DDT ST-DDT mentioned this pull request Jun 8, 2022
@xDivisionByZerox xDivisionByZerox added the m: location Something is referring to the location module label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: bug Something isn't working m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate why test address gps coords for non-metric sometimes fails

4 participants