feat: random numeric

[Shinigami92]

This introduce a new function beside alpha and alphaNumeric in the random module.
This function will later be used as a base for other faker functions like finance.pin and datatype.bigInt (#791).
It can also be used for potential new faker functions like internet.authCode.

[codecov]

Codecov Report

Merging #797 (2915439) into main (f797b63) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #797   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files        1958     1958           
  Lines      210804   210862   +58     
  Branches      905      919   +14     
=======================================
+ Hits       209590   209649   +59     
+ Misses       1157     1156    -1     
  Partials       57       57           

Impacted Files	Coverage Δ
src/random.ts	99.50% <100.00%> (+0.05%)	⬆️
src/index.ts	97.50% <0.00%> (+2.50%)	⬆️

[ejcheng]

Doesn't this do the same thing as finance.pin()?

[Shinigami92]

Doesn't this do the same thing as finance.pin()?

@import-brain: a little bit yes, but it is more like finance.pin can use this function. For the UX I would like to have both functions, but with a limited option set that is specialised for generating pin numbers. Maybe we also could add something like internet.authCode?
datatype.bigInt will also use this function.

@pkuczynski: @ST-DDT and I have short communication paths via personal friendship and discord, so we sometimes implement stuff together in our private space. I understand your suggestions, but sometimes we are a little bit ahead in thinking processes (e.g. in terms of how we want to re-structure the modules in "vFuture"). Not everything of that is somewhere to read because we are just thinking by communicating. So it might be that we want to go into another direction as you suggested.
But re-structuring modules will be anyways something for that far future.

[pkuczynski]

I noticed that you have short paths of communication, which is fine of course, but keeping the community away from it, is kind of demotivating... :/

[ST-DDT]

I noticed that you have short paths of communication, which is fine of course, but keeping the community away from it, is kind of demotivating... :/

Thanks for letting us know. We try to improve on this and establish regular team-meetings/be more open about it.
You can always ping us, if you have a specific topic you would like to discuss.
Things like this tend to come up during our reviews and it's hard to always communicate them.
(I usually tend to create issues for those things, but since this is only at the stage of we are thinking about it, I haven't done so yet)
I created a discussion for this idea of ours now: #805

If you notice again, that there are some things that haven't been communicated (well), then let us know.

[pkuczynski]

As suggested before I would put it in faker.string.numbers

[ejcheng]

I think this is fine where it is, don't think there's really a need to move it

[Shinigami92]

I think this is fine where it is, don't think there's really a need to move it

Thx, I also would like to move the module discussion into a later major and not bind it to these feature implementations

[pkuczynski]

Thx, I also would like to move the module discussion into a later major and not bind it to these feature implementations

Its a new function so it's not about moving it but rather putting in a future destination place... otherwise we will have to deprecate it and people will need to make an update on the next major release. Double the work. And seems that everybody agrees that datatype module should be gone...

[Shinigami92]

Deprecations should not be removed directly, but marked as for removal or moved to new location

[Shinigami92]

This PR adds a function in v6.2 to a module that already exists in v6
Adding a whole new module is a separate PR and targeted for v7 or later

[ST-DDT]

Just some minor things left.

Also what about:
#797 (comment)