feat: FakerError

[xDivisionByZerox]

closes #707

[codecov]

Codecov Report

Merging #718 (7d6001a) into main (48dcec1) will decrease coverage by 0.00%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1924     1925       +1     
  Lines      177010   177024      +14     
  Branches      908      909       +1     
==========================================
+ Hits       175858   175871      +13     
- Misses       1096     1097       +1     
  Partials       56       56              

Impacted Files	Coverage Δ
src/index.ts	95.00% <0.00%> (-2.44%)	⬇️
src/errors/faker-error.ts	100.00% <100.00%> (ø)
src/fake.ts	100.00% <100.00%> (ø)
src/faker.ts	100.00% <100.00%> (ø)
src/finance.ts	99.30% <100.00%> (+<0.01%)	⬆️
src/mersenne.ts	100.00% <100.00%> (ø)
src/random.ts	99.46% <100.00%> (+<0.01%)	⬆️
src/utils/unique.ts	95.23% <100.00%> (+0.07%)	⬆️

[Shinigami92]

Please re-export FakerError in src/index.ts

[xDivisionByZerox]

Please re-export FakerError in src/index.ts

How are things exported in the root index.ts? Is there any import/export order?
Should there be an index file in the errors directory? IMO this would make sense. If yes, would I make implicit or explicit exports in the root index file?

[Shinigami92]

@xDivisionByZerox You just want to do in src/index.ts

import { FakerError } from './errors/faker-error';
// ...
export { FakerError };

[xDivisionByZerox]

@xDivisionByZerox You just want to do in src/index.ts

import { FakerError } from './errors/faker-error';
// ...
export { FakerError };

But you know that this can be simplified, do you?

export{ FakerError } from './errors/faker-error';

That's why I was asking because I have seen these redundant import => export statements...

[Shinigami92]

But you know that this can be simplified, do you?

export{ FakerError } from './errors/faker-error';

That's why I was asking because I have seen these redundant import => export statements...

Yeah I know, but I'm not yet used to it

[pkuczynski]

export{ FakerError } from './errors/faker-error';

I personally actually prefer this form, as it's shorter and cleaner what comes from where...

[pkuczynski]

The export is still missing @xDivisionByZerox right?

[Shinigami92]

index export still missing

[xDivisionByZerox]

Yes the export was still missing but is implemented now.