feat(word): add sample method#714
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #714 +/- ##
==========================================
- Coverage 99.64% 99.63% -0.01%
==========================================
Files 2214 2214
Lines 238741 238813 +72
Branches 1023 1029 +6
==========================================
+ Hits 237885 237951 +66
- Misses 835 841 +6
Partials 21 21
|
|
@Shinigami92 anything else missing to get this merged? |
|
Yes, all the v6.1 targeted things to be merged I assume 🤔 |
Not sure if we should be so stick to the 6.1 is only bug fixes as keeping PRs open for longer time means potential conflicts and maintenance, so I would be in favor of merging things as soon as they ready... |
That is true. Is is a small feature, requiring low effort for maintaining the PR from you.
If we merge this one, then we have to explain why we didn't merge other features. We use the milestones as a means to communicate the order we discussed on when to tackle things/fix/add... We hope to finish all fixes/PRs for 6.1 by this Monday evening, so you don't have to maintain it forever either. |
|
Fair enough :) |
|
To consider: Handle "empty" locale |
|
Done. Ready for Review. |
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Fixes #276
Fixes #339