Conversation
Codecov Report
@@ Coverage Diff @@
## main #504 +/- ##
==========================================
+ Coverage 99.34% 99.35% +0.01%
==========================================
Files 1921 1922 +1
Lines 179522 182746 +3224
Branches 898 899 +1
==========================================
+ Hits 178345 181572 +3227
+ Misses 1121 1118 -3
Partials 56 56
|
|
We're starting work on the |
|
Yep sorry, kinda forgot about it... I'll do the rebase and the updates tomorrow! EDIT: ok I lied. I'm doing it RIGHT NOW! |
00a4cf1 to
e2dcf98
Compare
|
Sorry for the little mess in the commits, first time I rebased a forked repo 😅... |
Shinigami92
left a comment
There was a problem hiding this comment.
I found some non-emoji emojis 🤔 Not sure what to do with them or it is my system and a non-installed font
Did not saw them before, cause it was just a large chunk of icons. Now were everything is in it's own line, it's much better readable 🙂
|
@Shinigami92 You're right some were missing, I fixed it here: 4e239d7 |
|
I'm very busy today, so I will have a look at this tomorrow. |

fix: #497
So I added a function
faker.internet.emoji()that generate emojis.You can also filter only some groups of emoji with
faker.internet.emoji(["food"])for example.I took all the fully-qualified emoji of Unicode : https://unicode.org/Public/emoji/14.0/emoji-test.txt
I didn't separate each subgroup, as I don't think people need that much granularity.
I also disabled prettier on the
emoji.tsfile to have a more readable file so that you can spot the group names, but I can keep the prettier format if you prefer (I will have a huge lines number contribution 😛 !).For the test, I only check if the string has a length of at least 1, as the regex to check emoji are quite hacky for now.
I found using a package (such as this one: https://github.com/mathiasbynens/emoji-regex) only for this test to be unnecessary.