feat(food): add plant-based dish variety#3745
feat(food): add plant-based dish variety#3745xDivisionByZerox merged 2 commits intofaker-js:nextfrom
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi maintainers — just checking in on this. CI is green and the deploy preview is live. Happy to address any feedback on the data additions. Let me know if there's anything you'd like adjusted. |
|
Looks like you need to update the test snapshots. Please read contribution guide for further steps. |
|
Updated test snapshots as requested. Thanks for the review @Shinigami92! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3745 +/- ##
=======================================
Coverage 98.88% 98.88%
=======================================
Files 883 883
Lines 3061 3061
Branches 540 556 +16
=======================================
Hits 3027 3027
Misses 30 30
Partials 4 4 🚀 New features to boost your workflow:
|
xDivisionByZerox
left a comment
There was a problem hiding this comment.
Thanks for bringing in more diversity in this still "fresh" module.
|
Have you completed all steps of your test plan (or are they intentionally not checked)? |
|
All steps were completed — the checkboxes just weren't ticked before submission, sorry about that.
Checking them off now — all good to merge when you're ready. |
Summary
The food module's generated output currently skews heavily toward meat-based content:
dish_pattern.ts): 10 out of 15 patterns reference{{food.meat}}description_pattern.ts): 18 out of 21 templates reference{{food.meat}}dish.ts): 54 entries with limited plant-based representationThis PR adds diversity to the food module by:
dish.ts— all real dishes from world cuisines (aloo gobi, baba ganoush, chana masala, dal makhani, falafel wrap, ratatouille, etc.)dish_pattern.tsthat use{{food.vegetable}},{{food.fruit}},{{food.spice}}, and{{food.ingredient}}instead of{{food.meat}}description_pattern.tsthat showcase vegetable-forward dishesAll changes are purely additive — no existing entries were modified or removed. New dish entries are inserted in alphabetical order consistent with the existing array. This follows the precedent set by PR #3650.
Test plan
pnpm run generate:localescompletes without changes (locale data is already normalized)pnpm run preflightpassesfaker.food.dish()can return new plant-based dishesfaker.food.dishName()can generate plant-based patternsfaker.food.description()can generate plant-based descriptions