Skip to content

feat(locale): add Japanese bird definitions#3719

Merged
ST-DDT merged 6 commits intofaker-js:nextfrom
atzzCokeK:feat/ja-animal-bird
Mar 10, 2026
Merged

feat(locale): add Japanese bird definitions#3719
ST-DDT merged 6 commits intofaker-js:nextfrom
atzzCokeK:feat/ja-animal-bird

Conversation

@atzzCokeK
Copy link
Copy Markdown
Contributor

Summary

Add bird definitions for the Japanese (ja) locale.

This enables faker.animal.bird() to generate Japanese bird names.

Added files

bird.ts - Bird species (40 items)

Wild birds in Japan

スズメ, カラス, ハト, ツバメ, メジロ, ウグイス, シジュウカラ, etc.

Pet birds

インコ, オウム, カナリア, 文鳥, セキセイインコ, オカメインコ, etc.

References

Test plan

  • pnpm run generate:locales executed successfully
  • pnpm run preflight passed

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 31, 2026

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 182de82
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/69b08683cc79ea0008c4fa75
😎 Deploy Preview https://deploy-preview-3719.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.88%. Comparing base (c2c7342) to head (182de82).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3719   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files         886      886           
  Lines        3062     3062           
  Branches      556      556           
=======================================
  Hits         3028     3028           
  Misses         30       30           
  Partials        4        4           
Files with missing lines Coverage Δ
src/locales/ja/animal/index.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@atzzCokeK atzzCokeK marked this pull request as ready for review February 26, 2026 05:30
@atzzCokeK atzzCokeK requested a review from a team as a code owner February 26, 2026 05:30
@atzzCokeK atzzCokeK force-pushed the feat/ja-animal-bird branch 2 times, most recently from 4bdcdc8 to fa67589 Compare February 26, 2026 05:40
@ST-DDT
Copy link
Copy Markdown
Member

ST-DDT commented Feb 26, 2026

Looks like you merged two PRs together here.

@atzzCokeK
Copy link
Copy Markdown
Contributor Author

atzzCokeK commented Feb 26, 2026

@ST-DDT My bad, I will fix it!

Comment thread .takt/persona_sessions.json Outdated
Comment thread src/locales/ja/animal/bear.ts Outdated
@ST-DDT
Copy link
Copy Markdown
Member

ST-DDT commented Feb 27, 2026

Also force pushing, resets any review progress for the maintainers, so please only use it when neccessary.

And if you use AI, then make sure that you as a human review your submissions first!

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: animal Something is referring to the animal module labels Feb 27, 2026
@atzzCokeK
Copy link
Copy Markdown
Contributor Author

atzzCokeK commented Feb 27, 2026

And if you use AI, then make sure that you as a human review your submissions first!

@ST-DDT I am sorry, but honestly I did it by myself, not using AI with this fix.
Anyway, that is my mistake.

@atzzCokeK
Copy link
Copy Markdown
Contributor Author

Also force pushing, resets any review progress for the maintainers, so please only use it when neccessary.

I didn't know that happens in this project, I won't do it next time. Can I add this to CONTRIBUTING.md? If it is very common in OSS, just ignore me.

@atzzCokeK atzzCokeK requested a review from ST-DDT February 27, 2026 00:49
@xDivisionByZerox xDivisionByZerox added this pull request to the merge queue Mar 10, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 10, 2026
@ST-DDT ST-DDT added this pull request to the merge queue Mar 10, 2026
Merged via the queue into faker-js:next with commit dc31ff8 Mar 10, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions m: animal Something is referring to the animal module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants