Skip to content

feat(locales): add Norwegian (nb_NO) zodiac sign definitions#3711

Merged
xDivisionByZerox merged 1 commit intofaker-js:nextfrom
TomSchrier:feat/locale/nb_NO/western_zodiac_sign
Jan 28, 2026
Merged

feat(locales): add Norwegian (nb_NO) zodiac sign definitions#3711
xDivisionByZerox merged 1 commit intofaker-js:nextfrom
TomSchrier:feat/locale/nb_NO/western_zodiac_sign

Conversation

@TomSchrier
Copy link
Copy Markdown
Contributor

In this PR, I add the zodiac sign definitions for the Norwegian (nb_NO) locale.

I used the following table as the source for the translations:

Skjermbilde 2026-01-28 kl  18 32 23

Taken from: https://snl.no/stjerneteikn

@TomSchrier TomSchrier requested a review from a team as a code owner January 28, 2026 17:34
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 28, 2026

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 16490d2
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/697a48b9dd33d30008b51dcd
😎 Deploy Preview https://deploy-preview-3711.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Shinigami92 Shinigami92 added c: locale Permutes locale definitions m: person Something is referring to the person module labels Jan 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.97%. Comparing base (e7f3ccd) to head (16490d2).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3711   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        3000     3001    +1     
  Lines      236293   236309   +16     
  Branches      944      943    -1     
=======================================
+ Hits       236235   236251   +16     
  Misses         58       58           
Files with missing lines Coverage Δ
src/locales/nb_NO/person/index.ts 100.00% <100.00%> (ø)
src/locales/nb_NO/person/western_zodiac_sign.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xDivisionByZerox xDivisionByZerox added c: feature Request for new feature p: 1-normal Nothing urgent labels Jan 28, 2026
@xDivisionByZerox xDivisionByZerox added this to the v10.x milestone Jan 28, 2026
@xDivisionByZerox xDivisionByZerox added this pull request to the merge queue Jan 28, 2026
@xDivisionByZerox
Copy link
Copy Markdown
Member

Thank you for your contribution 🙌 ❤️

Merged via the queue into faker-js:next with commit e306542 Jan 28, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: feature Request for new feature c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants