fix(locale): ko modified street_name to street_name_part#3485
Merged
xDivisionByZerox merged 5 commits intofaker-js:nextfrom May 13, 2025
Merged
fix(locale): ko modified street_name to street_name_part#3485xDivisionByZerox merged 5 commits intofaker-js:nextfrom
xDivisionByZerox merged 5 commits intofaker-js:nextfrom
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3485 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 2880 2880
Lines 220417 220507 +90
Branches 949 949
=======================================
+ Hits 220362 220454 +92
+ Misses 55 53 -2
🚀 New features to boost your workflow:
|
Contributor
|
Could you split the state name changes to a separate PR? Keeps it cleaner. |
seoahan
force-pushed
the
next
branch
2 times, most recently
from
f2b68b4 to
d0461cd
Compare
Contributor
Author
Yes, I've split the state name changes to this PR: #3487 |
xDivisionByZerox
added
p: 1-normal
ejcheng
approved these changes
May 9, 2025
matthewmayer
approved these changes
May 9, 2025
Shinigami92
approved these changes
May 12, 2025
xDivisionByZerox
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed street pattern usage for ko locale #2062
street_name.tsmodified tostreet_name_part.ts.street_pattern.tscorrespondingly modified.Additionally:
Updated data to more accurately represent state names and street names.
Street names:
Added data to
street_name_part.ts(formerlystreet_name.ts).Added and modified data in
street_suffix.ts. The previous suffixes instreet_suffix.tswere not suffixes for street names, but rather for zones/areas. Modified the suffixes for accuracy, and added additional suffixes involving numbers as common for Korean street names.State names:
Changes to state names have been moved to PR #3487