fix(location): fix US ZIP code anomalies for zipCode({state})#3180
Merged
ST-DDT merged 2 commits intofaker-js:nextfrom Oct 16, 2024
Merged
fix(location): fix US ZIP code anomalies for zipCode({state})#3180ST-DDT merged 2 commits intofaker-js:nextfrom
ST-DDT merged 2 commits intofaker-js:nextfrom
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3180 +/- ##
========================================
Coverage 99.96% 99.96%
========================================
Files 2798 2798
Lines 227328 227367 +39
Branches 577 957 +380
========================================
+ Hits 227255 227298 +43
+ Misses 73 69 -4
|
ST-DDT
approved these changes
Oct 13, 2024
Shinigami92
approved these changes
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #3169
takes advantage of the new syntax allowed by #3170
Fixes issues where
fakerEN_US.zipCode({state:"XX"})would give a ZIP code in the wrong state, due to various anomalies:After this PR there should be no cases where
fakerEN_US.zipCode({state:"XX"})gives a valid ZIP in another state, although there are still many cases where it gives an invalid ZIP (but this is impossible to prevent without shipping a list of every possible ZIP).