feat(locale): add Swedish(sv) counties#3154
Merged
ST-DDT merged 3 commits intofaker-js:nextfrom Oct 10, 2024
johanholmerin:sv-county
Merged
feat(locale): add Swedish(sv) counties#3154ST-DDT merged 3 commits intofaker-js:nextfrom johanholmerin:sv-county
ST-DDT merged 3 commits intofaker-js:nextfrom
johanholmerin:sv-county
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3154 +/- ##
==========================================
- Coverage 99.96% 99.96% -0.01%
==========================================
Files 2796 2797 +1
Lines 227483 227777 +294
Branches 953 958 +5
==========================================
+ Hits 227410 227702 +292
- Misses 73 75 +2
|
ejcheng
previously approved these changes
Oct 2, 2024
Contributor
|
Generally state() returns the "level 1 administrative areas" and county() returns the "level 2 administrative areas" regardless of what they are actually called in that language. Does that make sense for sv? |
Contributor
Author
|
Thanks @matthewmayer, that helped make things clearer. I've switched to using municipalities(kommuner) instead(based on the official list at https://skr.se/skr/tjanster/kommunerochregioner/kommunerlista.1246.html). The län were already available as state(). |
xDivisionByZerox
approved these changes
Oct 10, 2024
ST-DDT
approved these changes
Oct 10, 2024
Shinigami92
approved these changes
Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the list at https://sv.wikipedia.org/wiki/Sveriges_l%C3%A4n#Lista_%C3%B6ver_Sveriges_l%C3%A4n
Note: although län is the administrative area that translates to counties, it would also be useful to have support for municipalities(kommuner), since that's whats used for addresses in Sweden.