Skip to content

fix(locale): correction of pt_PT location and person data#3020

Merged
ST-DDT merged 6 commits intofaker-js:nextfrom
jeanpierrecarvalho:jpcarvalho/fix/fix-issues-on-portuguese-language
Sep 16, 2024
Merged

fix(locale): correction of pt_PT location and person data#3020
ST-DDT merged 6 commits intofaker-js:nextfrom
jeanpierrecarvalho:jpcarvalho/fix/fix-issues-on-portuguese-language

Conversation

@jeanpierrecarvalho
Copy link
Copy Markdown
Contributor

@jeanpierrecarvalho jeanpierrecarvalho commented Jul 15, 2024

Issue #3020: Correction of pt_PT Information

Changes Made:

Corrected country, region names an person info in Portuguese (pt_PT) in the data file.

Details of Changes:

  • Updated the list of country names to use proper Portuguese translations.
  • Ensured consistency in the use of special characters and accents according to the pt_PT locale.
  • Verified and corrected abbreviations for various titles and street types in Portuguese.
  • Update last names and prefix info in person

Additional Details:

The corrections were made to improve localization and ensure accurate representation of country names and titles in Portuguese.

@jeanpierrecarvalho jeanpierrecarvalho requested a review from a team as a code owner July 15, 2024 21:30
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 15, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 9c4d8ed
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66e87b3c06c3b000080796bb
😎 Deploy Preview https://deploy-preview-3020.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jeanpierrecarvalho
Copy link
Copy Markdown
Contributor Author

Hi @ST-DDT, just recreated this one. Can you have a look, please?

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Jul 15, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Jul 15, 2024
@ST-DDT ST-DDT added m: location Something is referring to the location module m: person Something is referring to the person module labels Jul 15, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (af01db9) to head (9c4d8ed).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3020   +/-   ##
=======================================
  Coverage   99.96%   99.97%           
=======================================
  Files        2776     2776           
  Lines      226262   226338   +76     
  Branches      940      944    +4     
=======================================
+ Hits       226181   226272   +91     
+ Misses         81       66   -15     
Files with missing lines Coverage Δ
src/locales/pt_PT/location/country.ts 100.00% <100.00%> (ø)
src/locales/pt_PT/location/secondary_address.ts 100.00% <100.00%> (ø)
src/locales/pt_PT/location/state.ts 100.00% <100.00%> (ø)
src/locales/pt_PT/person/last_name.ts 100.00% <100.00%> (ø)
src/locales/pt_PT/person/prefix.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Comment thread src/locales/pt_PT/person/last_name.ts Outdated
@ST-DDT ST-DDT changed the title fix: correction of pt_PT information fix(locale): correction of pt_PT information Jul 16, 2024
@ST-DDT ST-DDT requested review from a team July 16, 2024 14:40
@matthewmayer matthewmayer changed the title fix(locale): correction of pt_PT information fix(locale): correction of pt_PT location and person data Jul 21, 2024
Comment thread src/locales/pt_PT/person/prefix.ts
@ST-DDT ST-DDT enabled auto-merge (squash) September 16, 2024 18:38
@ST-DDT ST-DDT merged commit 3e47ee7 into faker-js:next Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions m: location Something is referring to the location module m: person Something is referring to the person module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants