You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why do we couple file anme and property key anyway? The propblem I have right now is that we have locale entries which might be lists of objects which intern have property keys as well. These are not considered in the PR. For example, look at en/airline/airline which is types as a list of Airline. It has the property iataCode, which is camelCase. So what I can do is faker.helpers.fake('airline.airline.iataCode') which contradictes the statement from the migration guide:
All our locale data now use the snake_case naming scheme.
If you are just concerned about the wording, I can change it to refer to locale categories and entries specifically.
Thats propably it for me. Alternativly we could actually make all properties snake_case. The definition properties which are not "correctly" cased right now (ignoring the ones from this PR) are:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breaking changeCannot be merged when next version is not a major releasec: localePermutes locale definitionsc: refactorPR that affects the runtime behavior, but doesn't add new features or fixes bugsp: 1-normalNothing urgent
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize file naming convention for the renaming locale files.
faker.definitions.science.chemicalElementfaker.definitions.science.chemical_elementfaker.definitions.system.directoryPathsfaker.definitions.system.directory_pathsfaker.definitions.system.mimeTypesfaker.definitions.system.mime_typesThis is an attempt an fixing some TODOs in our sources.