Skip to content

fix(person): workaround for inherited first- and lastNames#2834

Merged
ST-DDT merged 2 commits intofaker-js:nextfrom
matthewmayer:fix/gendered-names
Apr 19, 2024
Merged

fix(person): workaround for inherited first- and lastNames#2834
ST-DDT merged 2 commits intofaker-js:nextfrom
matthewmayer:fix/gendered-names

Conversation

@matthewmayer
Copy link
Copy Markdown
Contributor

fix #2833

merges male and female last names for

sk
id_ID
lv
ru
uk
az
uz_UZ_latin

merges male and female first names for

th
uz_UZ_latin

@matthewmayer matthewmayer requested a review from a team as a code owner April 18, 2024 12:29
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 18, 2024

Deploy Preview for fakerjs canceled.

Name Link
🔨 Latest commit f5b3ea6
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66227e4b09db0700086ffee8

@matthewmayer matthewmayer self-assigned this Apr 18, 2024
@matthewmayer matthewmayer added m: person Something is referring to the person module p: 1-normal Nothing urgent labels Apr 18, 2024
@matthewmayer matthewmayer added this to the v9.0 milestone Apr 18, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (6c845c4) to head (f5b3ea6).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2834      +/-   ##
==========================================
- Coverage   99.96%   99.95%   -0.01%     
==========================================
  Files        2964     2973       +9     
  Lines      212544   212613      +69     
  Branches      599      948     +349     
==========================================
+ Hits       212466   212519      +53     
- Misses         78       94      +16     
Files Coverage Δ
src/locales/az/person/index.ts 100.00% <100.00%> (ø)
src/locales/az/person/last_name.ts 100.00% <100.00%> (ø)
src/locales/id_ID/person/index.ts 100.00% <100.00%> (ø)
src/locales/id_ID/person/last_name.ts 100.00% <100.00%> (ø)
src/locales/lv/person/index.ts 100.00% <100.00%> (ø)
src/locales/lv/person/last_name.ts 100.00% <100.00%> (ø)
src/locales/ru/person/index.ts 100.00% <100.00%> (ø)
src/locales/ru/person/last_name.ts 100.00% <100.00%> (ø)
src/locales/sk/person/index.ts 100.00% <100.00%> (ø)
src/locales/sk/person/last_name.ts 100.00% <100.00%> (ø)
... and 7 more

... and 1 file with indirect coverage changes

Copy link
Copy Markdown
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accept this as a workaround, until the actual bug is fixed in v9.0.

@ST-DDT ST-DDT added the c: locale Permutes locale definitions label Apr 18, 2024
@ST-DDT ST-DDT changed the title fix(person): fix lastName and firstName when no gender specified in some locales fix(person): workaround for incorrectly inherited first- and lastNames Apr 18, 2024
@ST-DDT ST-DDT requested review from a team April 18, 2024 13:25
@ST-DDT ST-DDT changed the title fix(person): workaround for incorrectly inherited first- and lastNames fix(person): workaround for inherited first- and lastNames Apr 19, 2024
@ST-DDT ST-DDT enabled auto-merge (squash) April 19, 2024 14:23
@ST-DDT ST-DDT merged commit 016a5b6 into faker-js:next Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Localization lastName is not working

3 participants