Merged
Conversation
xDivisionByZerox
added
p: 1-normal
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ST-DDT
previously approved these changes
Apr 7, 2024
Member
ST-DDT
left a comment
ST-DDT
left a comment
There was a problem hiding this comment.
The test snapshots need to be updated, but otherwise this looks good to me.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2791 +/- ##
==========================================
- Coverage 99.96% 99.95% -0.01%
==========================================
Files 2971 2971
Lines 212696 212619 -77
Branches 949 945 -4
==========================================
- Hits 212617 212526 -91
- Misses 79 93 +14
|
matthewmayer
reviewed
Apr 8, 2024
Contributor
matthewmayer
left a comment
matthewmayer
left a comment
There was a problem hiding this comment.
Is there anything we can do to speed up the normalisation code? It seems to add several seconds to every preflight run even when only running for a couple of modules.
ST-DDT
previously approved these changes
Apr 8, 2024
Shinigami92
previously approved these changes
Apr 8, 2024
Member
Author
Guess we can parallelize the processing of all methods in a module as well as the module processing in general. This would not fix the data normalization in general, tho. Any ideas on that? |
xDivisionByZerox
dismissed stale reviews from Shinigami92 and ST-DDT
via
bd505fe
xDivisionByZerox
force-pushed
the
refactor/locale/normalize-animal-data
branch
from
bd505fe to
3cd809c
Compare
ST-DDT
approved these changes
Apr 9, 2024
Shinigami92
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-on to #2265
Normalize the entries in the
animalmodule definitions in all locales.I choose this module as only one file (
src/locales/fr/animal/bird.ts) that exceeded the entry limit. Th rest of the changes come from sorting and deduping the datasets.