Skip to content

fix(internet): add Hebrew username charMapping#2781

Merged
ST-DDT merged 4 commits intofaker-js:nextfrom
mordi9:patch-1
Apr 4, 2024
Merged

fix(internet): add Hebrew username charMapping#2781
ST-DDT merged 4 commits intofaker-js:nextfrom
mordi9:patch-1

Conversation

@mordi9
Copy link
Copy Markdown
Contributor

@mordi9 mordi9 commented Apr 1, 2024

instead of getting such a result
15t15q15f160.15c15l16215r@hotmail.com
Following #2776

@mordi9 mordi9 requested a review from a team as a code owner April 1, 2024 12:03
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 1, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit a03ffe2
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/660f0927afda5e00084dd65c
😎 Deploy Preview https://deploy-preview-2781.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ST-DDT ST-DDT changed the title Update char-mappings.ts to hebrew fix(internet): add Hebrew username charMapping Apr 1, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (next@ec3959c). Click here to learn what that means.

❗ Current head eaddf76 differs from pull request most recent head a03ffe2. Consider uploading reports for the commit a03ffe2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2781   +/-   ##
=======================================
  Coverage        ?   99.93%           
=======================================
  Files           ?     2973           
  Lines           ?   212561           
  Branches        ?      602           
=======================================
  Hits            ?   212420           
  Misses          ?      137           
  Partials        ?        4           
Files Coverage Δ
src/modules/internet/char-mappings.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT added c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug m: internet Something is referring to the internet module labels Apr 1, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Apr 1, 2024
@ST-DDT ST-DDT linked an issue Apr 1, 2024 that may be closed by this pull request
10 tasks
Copy link
Copy Markdown
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be able to automatically fix it with: pnpm run lint --fix

Comment thread src/modules/internet/char-mappings.ts Outdated
@matthewmayer
Copy link
Copy Markdown
Contributor

Here's 100 outputs:

'chnyt_kysry27@yahoo.com',
  'anbl.bytyvsph40@hotmail.com',
  'ravt77@gmail.com',
  'alksndr14@hotmail.com',
  'glbva27@hotmail.com',
  'ktyh_artsy68@hotmail.com',
  'tvm_bnravbn@gmail.com',
  'yalh37@gmail.com',
  'ntnal.glbva83@yahoo.com',
  'nykvls_lydvr84@yahoo.com',
  'mvryh_zkvt@hotmail.com',
  'tvbh_tshby@gmail.com',
  'rvnyt65@yahoo.com',
  'lvy94@yahoo.com',
  'alma98@gmail.com',
  'aylay71@yahoo.com',
  'dgn.knr68@gmail.com',
  'shavl57@hotmail.com',
  'ravt_avryh@gmail.com',
  'lb23@yahoo.com',
  'lyavn.bytyvsph@gmail.com',
  'ygal_gdrvn@yahoo.com',
  'chmy_bnyshral@hotmail.com',
  'shyrh88@hotmail.com',
  'yvab19@gmail.com',
  'adn.mshany@hotmail.com',
  'yrdn74@yahoo.com',
  'vyktvryh_alyab@gmail.com',
  'lshm.ashbl@yahoo.com',
  'rn.ydyn@yahoo.com',
  'shchr.gdvt12@yahoo.com',
  'ydyd33@hotmail.com',
  'yftch.ksht@gmail.com',
  'avfl_tsvk70@gmail.com',
  'yrdn.bchvr@hotmail.com',
  'yhvntn19@yahoo.com',
  'avrly.mshh@yahoo.com',
  'ym_knan@yahoo.com',
  'drvr_atsmvn43@hotmail.com',
  'shyrh25@hotmail.com',
  'nvah_avbdyh53@yahoo.com',
  'alchnn_adyny@hotmail.com',
  'syny_bram@yahoo.com',
  'rvn16@yahoo.com',
  'mrym_shr67@yahoo.com',
  'styv_dvtn@hotmail.com',
  'dnyalh0@yahoo.com',
  'shkmh59@hotmail.com',
  'yal_agrvn@hotmail.com',
  'yvbl35@hotmail.com',
  'aylay_tsmch97@hotmail.com',
  'avfk.bravr33@hotmail.com',
  'avz92@hotmail.com',
  'thylh29@yahoo.com',
  'lvy_fld44@hotmail.com',
  'nvah.bnaryh@yahoo.com',
  'yhl.shny96@yahoo.com',
  'dnyalh_kvrn@gmail.com',
  'yvgb88@yahoo.com',
  'afryl_bram93@hotmail.com',
  'flg29@hotmail.com',
  'ayylt16@gmail.com',
  'chmvtl_asys45@hotmail.com',
  'amlyh.mrvm@yahoo.com',
  'hll95@yahoo.com',
  'gl_ksfy86@gmail.com',
  'rgb78@gmail.com',
  'lbnh.advny@gmail.com',
  'chbyb.gbavn@gmail.com',
  'avhd_bnshchr81@hotmail.com',
  'ashr97@gmail.com',
  'syny30@gmail.com',
  'avfyrh_nshr@hotmail.com',
  'nytay.shbyb17@yahoo.com',
  'lyan8@hotmail.com',
  'gyvra33@yahoo.com',
  'mykl95@hotmail.com',
  'alvn.kynn@gmail.com',
  'adn24@gmail.com',
  'avmry_gl1@yahoo.com',
  'kvryn_abnvn@yahoo.com',
  'mgl.shlv53@hotmail.com',
  'shchk.bngl68@yahoo.com',
  'nchshvn_nvvh48@gmail.com',
  'lyrvy92@yahoo.com',
  'avzyh98@yahoo.com',
  'rvn13@hotmail.com',
  'lyrvy_lbary@yahoo.com',
  'smdr_chryph86@yahoo.com',
  'abytl_ntnal@gmail.com',
  'chnn79@hotmail.com',
  'rbyb_chryph98@yahoo.com',
  'alvmh_shvb@yahoo.com',
  'rvtm_mvryh34@yahoo.com',
  'nytay.mavz16@gmail.com',
  'rbkh5@yahoo.com',
  'dfnh86@gmail.com',
  'tyav_drvr40@yahoo.com',
  'shryt_frch@gmail.com',
  'ayb.aylt@gmail.com'

@ST-DDT ST-DDT requested review from a team April 4, 2024 16:26
Copy link
Copy Markdown
Contributor

@matthewmayer matthewmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, the resulting emails look better than before. they are a bit short on vowels, but that's just how Hebrew works

@ST-DDT ST-DDT enabled auto-merge (squash) April 4, 2024 20:11
@ST-DDT ST-DDT merged commit 5860783 into faker-js:next Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: bug Something isn't working m: internet Something is referring to the internet module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Email addresses are unknown on fakerHE in Hebrew

4 participants