fix(internet): add Hebrew username charMapping#2781
Merged
ST-DDT merged 4 commits intofaker-js:nextfrom Apr 4, 2024
Merged
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2781 +/- ##
=======================================
Coverage ? 99.93%
=======================================
Files ? 2973
Lines ? 212561
Branches ? 602
=======================================
Hits ? 212420
Misses ? 137
Partials ? 4
|
10 tasks
ST-DDT
requested changes
Apr 1, 2024
Member
ST-DDT
left a comment
There was a problem hiding this comment.
You might be able to automatically fix it with: pnpm run lint --fix
Contributor
|
Here's 100 outputs: |
ST-DDT
approved these changes
Apr 4, 2024
matthewmayer
approved these changes
Apr 4, 2024
Contributor
matthewmayer
left a comment
There was a problem hiding this comment.
looks good to me, the resulting emails look better than before. they are a bit short on vowels, but that's just how Hebrew works
Shinigami92
approved these changes
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of getting such a result
15t15q15f160.15c15l16215r@hotmail.com
Following #2776