Skip to content

refactor(git)!: remove v8 deprecated git method#2716

Merged
ST-DDT merged 4 commits intonextfrom
remove-deprecated-git-method
Mar 6, 2024
Merged

refactor(git)!: remove v8 deprecated git method#2716
ST-DDT merged 4 commits intonextfrom
remove-deprecated-git-method

Conversation

@Shinigami92
Copy link
Copy Markdown
Member

No description provided.

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release m: git Something is referring to the git module labels Mar 5, 2024
@Shinigami92 Shinigami92 added this to the v9.0 milestone Mar 5, 2024
@Shinigami92 Shinigami92 self-assigned this Mar 5, 2024
@Shinigami92 Shinigami92 force-pushed the remove-deprecated-git-method branch from eb0fc5d to dbee57b Compare March 5, 2024 11:02
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (2716865) to head (2b9c766).

❗ Current head 2b9c766 differs from pull request most recent head 4961aed. Consider uploading reports for the commit 4961aed to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2716   +/-   ##
=======================================
  Coverage   99.57%   99.58%           
=======================================
  Files        2859     2859           
  Lines      248934   248859   -75     
  Branches      990      991    +1     
=======================================
- Hits       247871   247814   -57     
+ Misses       1034     1016   -18     
  Partials       29       29           
Files Coverage Δ
src/modules/git/index.ts 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

Comment thread src/modules/git/index.ts Outdated
@Shinigami92 Shinigami92 marked this pull request as ready for review March 5, 2024 11:14
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 5, 2024 11:14
@Shinigami92 Shinigami92 requested a review from a team March 5, 2024 11:14
@ST-DDT ST-DDT requested a review from a team March 5, 2024 11:37
@ST-DDT ST-DDT requested a review from a team March 5, 2024 15:17
@ST-DDT ST-DDT enabled auto-merge (squash) March 6, 2024 16:47
@ST-DDT ST-DDT merged commit b3afc8f into next Mar 6, 2024
@ST-DDT ST-DDT deleted the remove-deprecated-git-method branch March 15, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: git Something is referring to the git module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants