Skip to content

refactor(date)!: remove v8 deprecated date methods#2704

Merged
ST-DDT merged 4 commits intonextfrom
remove-deprecated-date-methods
Mar 5, 2024
Merged

refactor(date)!: remove v8 deprecated date methods#2704
ST-DDT merged 4 commits intonextfrom
remove-deprecated-date-methods

Conversation

@Shinigami92
Copy link
Copy Markdown
Member

No description provided.

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release labels Mar 3, 2024
@Shinigami92 Shinigami92 added this to the v9.0 milestone Mar 3, 2024
@Shinigami92 Shinigami92 self-assigned this Mar 3, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (2bf8974) to head (0e5fc48).

❗ Current head 0e5fc48 differs from pull request most recent head 72efe2d. Consider uploading reports for the commit 72efe2d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2704      +/-   ##
==========================================
- Coverage   99.57%   99.56%   -0.02%     
==========================================
  Files        2859     2846      -13     
  Lines      249642   247998    -1644     
  Branches     1009      627     -382     
==========================================
- Hits       248582   246908    -1674     
- Misses       1060     1090      +30     
Files Coverage Δ
src/modules/date/index.ts 99.82% <100.00%> (-0.10%) ⬇️

... and 17 files with indirect coverage changes

@Shinigami92 Shinigami92 force-pushed the remove-deprecated-date-methods branch from 0748d6c to cf53240 Compare March 3, 2024 10:25
@Shinigami92 Shinigami92 marked this pull request as ready for review March 3, 2024 10:25
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 3, 2024 10:25
@Shinigami92 Shinigami92 changed the title refactor(internet)!: remove v8 deprecated date methods refactor(date)!: remove v8 deprecated date methods Mar 3, 2024
Comment thread test/all-functional.spec.ts
@Shinigami92 Shinigami92 added the s: needs decision Needs team/maintainer decision label Mar 3, 2024
@ST-DDT ST-DDT removed the s: needs decision Needs team/maintainer decision label Mar 4, 2024
@ST-DDT ST-DDT requested review from a team and matthewmayer March 4, 2024 12:51
@ST-DDT ST-DDT enabled auto-merge (squash) March 5, 2024 09:53
@ST-DDT ST-DDT merged commit e868060 into next Mar 5, 2024
@ST-DDT ST-DDT deleted the remove-deprecated-date-methods branch March 5, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants