fix(finance): maskedNumber has incorrect defaults

[ST-DDT]

Fix the incorrect defaults introduced in #2055

• refactor(finance): rename mask to maskedNumber #2055

See also:

• Merge-Commit
• PR #2055 diff

---

Alternative solution:

• Change the documented defaults

Additional suggestion:

Deprecate the method entirely (because it is probably more useful if done like this by the user:

someMethod().replace(/(?<=.{4})\w(?=.{2})/g,'*')

which converts DE241358431563434532 to DE24**************32

We should probably document that somewhere in our docs too, although I assume they should already have something similar in their code somewhere.

[codecov]

Codecov Report

Merging #2494 (e62fb5b) into next (8542ef3) will increase coverage by 0.00%.
Report is 1 commits behind head on next.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #2494   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files        2779     2779           
  Lines      249273   249273           
  Branches     1084     1084           
=======================================
+ Hits       248230   248232    +2     
+ Misses       1015     1013    -2     
  Partials       28       28           

Files	Coverage Δ
src/modules/finance/index.ts	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

[matthewmayer]

Given that the defaults were accidentally changed during a method rename and we didn't catch that, suggests there should be a test for that? e.g. check that maskedNumber() with no params includes (... )

[ST-DDT]

Given that the defaults were accidentally changed during a method rename and we didn't catch that, suggests there should be a test for that? e.g. check that maskedNumber() with no params includes (... )

Done