refactor(locale)!: remove location data index-value-binding by xDivisionByZerox · Pull Request #2476 · faker-js/faker

xDivisionByZerox · 2023-10-13T23:29:48Z

Removes the requirement for direction locale data lists to be sorted in a specific order.

codecov · 2023-10-13T23:35:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (734a7f3) to head (d4ed4f5).

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #2476      +/-   ##
==========================================
- Coverage   99.96%   99.95%   -0.01%     
==========================================
  Files        2971     2966       -5     
  Lines      212620   212579      -41     
  Branches      597      950     +353     
==========================================
- Hits       212546   212490      -56     
- Misses         74       89      +15

Files	Coverage Δ
src/locales/da/location/direction.ts	`100.00% <100.00%> (ø)`
src/locales/da/location/index.ts	`100.00% <ø> (ø)`
src/locales/en/location/direction.ts	`100.00% <100.00%> (ø)`
src/locales/en/location/index.ts	`100.00% <ø> (ø)`
src/locales/eo/location/direction.ts	`100.00% <100.00%> (ø)`
src/locales/eo/location/index.ts	`100.00% <ø> (ø)`
src/locales/fa/location/direction.ts	`100.00% <100.00%> (ø)`
src/locales/fr/location/direction.ts	`100.00% <100.00%> (ø)`
src/locales/fr_CH/location/direction.ts	`100.00% <100.00%> (ø)`
src/locales/he/location/direction.ts	`100.00% <100.00%> (ø)`
... and 9 more

... and 1 file with indirect coverage changes

ST-DDT · 2023-10-14T08:45:52Z

Looks good to me.
Not sure whether we should push this in v8 or v9.

…dex-from-representation-value

ST-DDT · 2023-11-01T23:27:29Z

Since we change the layout of our locale data, I think we should merge this in v9.0.

ST-DDT

I checked that no new files have been added in the meantime.

Shinigami92

docs/guide/upgrading_v9/2476.md file required

xDivisionByZerox · 2024-03-10T00:41:03Z

Looking at #2505, would it make sense to "flatten" this definitions as well? So instead of direction object with nested properties, we'd have 4 files/4properties on the location definition object.

ST-DDT · 2024-03-10T01:00:05Z

Looking at #2505, would it make sense to "flatten" this definitions as well? So instead of direction object with nested properties, we'd have 4 files/4properties on the location definition object.

We could do that, but these files are so small, that it would be harder to review the files if split up.
IMO we keep them in a single file.

…dex-from-representation-value

netlify · 2024-04-06T18:11:14Z

✅ Deploy Preview for fakerjs ready!

Name	Link
🔨 Latest commit	`d4ed4f5`
🔍 Latest deploy log	https://app.netlify.com/sites/fakerjs/deploys/661c55b5d613c40008908b8f
😎 Deploy Preview	https://deploy-preview-2476.fakerjs.dev
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

xDivisionByZerox · 2024-04-06T19:48:12Z

I put "needs decision" as I'd like to discuss my last comment in the next team meeting.

…dex-from-representation-value

ST-DDT · 2024-04-11T17:40:28Z

Team Decision

We will not flatten the definitions in the same way as #2505 .

Reason:

Being a nested object ensures that all values are always present, as the type requires it. On the other hand entries in categories are optional by force and thus it might lead to cases where abbr is set but the full value is missing.

…dex-from-representation-value

refactor(locale): remove location data index-value-coupling

ebfdb87

xDivisionByZerox added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Oct 13, 2023

xDivisionByZerox requested a review from a team October 13, 2023 23:29

xDivisionByZerox self-assigned this Oct 13, 2023

xDivisionByZerox requested a review from a team as a code owner October 13, 2023 23:29

xDivisionByZerox mentioned this pull request Oct 13, 2023

infra: implement inactive locales content generation enhancement #2265

Merged

ST-DDT added the c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs label Oct 14, 2023

ST-DDT previously approved these changes Oct 14, 2023

View reviewed changes

ST-DDT added 2 commits October 20, 2023 01:14

Merge branch 'next' into refactor/location/decouple-direction-data-in…

28fbb1c

…dex-from-representation-value

Merge branch 'next' into refactor/location/decouple-direction-data-in…

08f7c97

…dex-from-representation-value

matthewmayer requested changes Oct 20, 2023

View reviewed changes

Comment thread src/locales/fa/location/direction.ts Outdated

matthewmayer added the breaking change Cannot be merged when next version is not a major release label Oct 21, 2023

ST-DDT added the s: needs decision Needs team/maintainer decision label Oct 21, 2023

ST-DDT and others added 2 commits October 30, 2023 10:37

Merge branch 'next' into refactor/location/decouple-direction-data-in…

d18f98b

…dex-from-representation-value

refactor: add empty abbreviated directions

9318da8

xDivisionByZerox dismissed ST-DDT’s stale review via 9318da8 November 1, 2023 16:29

matthewmayer removed the breaking change Cannot be merged when next version is not a major release label Nov 1, 2023

ST-DDT added this to the v9.0 milestone Nov 1, 2023

ST-DDT approved these changes Nov 1, 2023

View reviewed changes

ST-DDT added the do NOT merge yet Do not merge this PR into the target branch yet label Nov 1, 2023

xDivisionByZerox requested a review from matthewmayer November 18, 2023 11:34

matthewmayer previously approved these changes Nov 20, 2023

View reviewed changes

xDivisionByZerox added breaking change Cannot be merged when next version is not a major release and removed s: needs decision Needs team/maintainer decision labels Dec 4, 2023

xDivisionByZerox changed the title ~~refactor(locale): remove location data index-value-binding~~ refactor(locale)!: remove location data index-value-binding Dec 4, 2023

ST-DDT requested changes Feb 8, 2024

View reviewed changes

Comment thread src/definitions/location.ts Outdated

Shinigami92 requested changes Feb 9, 2024

View reviewed changes

xDivisionByZerox mentioned this pull request Mar 12, 2024

refactor(company)!: remove v8 deprecated company methods #2726

Merged

Merge branch 'next' into refactor/location/decouple-direction-data-in…

f2a752f

…dex-from-representation-value

xDivisionByZerox added 2 commits April 6, 2024 20:37

refactor(LocationDefinition): remove direction_abbr property

b7bcb6f

refactor(locale): update uz_UZ direction

3235914

xDivisionByZerox dismissed matthewmayer’s stale review via 3235914 April 6, 2024 19:32

xDivisionByZerox added the s: needs decision Needs team/maintainer decision label Apr 6, 2024

docs: add migration snippet

4fb6917

ST-DDT approved these changes Apr 6, 2024

View reviewed changes

Shinigami92 approved these changes Apr 8, 2024

View reviewed changes

Merge branch 'next' into refactor/location/decouple-direction-data-in…

4ed9ee3

…dex-from-representation-value

xDivisionByZerox added the do NOT merge yet Do not merge this PR into the target branch yet label Apr 8, 2024

Shinigami92 approved these changes Apr 11, 2024

View reviewed changes

Merge branch 'next' into refactor/location/decouple-direction-data-in…

a7de0ab

…dex-from-representation-value

ST-DDT removed the s: needs decision Needs team/maintainer decision label Apr 11, 2024

ST-DDT requested review from a team April 11, 2024 17:41

ST-DDT removed the do NOT merge yet Do not merge this PR into the target branch yet label Apr 11, 2024

ST-DDT requested a review from matthewmayer April 11, 2024 17:41

Merge branch 'next' into refactor/location/decouple-direction-data-in…

d4ed4f5

…dex-from-representation-value

ST-DDT merged commit 453ea97 into next Apr 14, 2024

ST-DDT deleted the refactor/location/decouple-direction-data-index-from-representation-value branch April 14, 2024 22:27

xDivisionByZerox mentioned this pull request May 5, 2024

Simplify address.direction #1228

Closed

matthewmayer added a commit that referenced this pull request Jun 4, 2024

docs: document breaking changes for #2476 into migration guide

f4aef77

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(locale)!: remove location data index-value-binding#2476

refactor(locale)!: remove location data index-value-binding#2476
ST-DDT merged 13 commits intonextfrom
refactor/location/decouple-direction-data-index-from-representation-value

xDivisionByZerox commented Oct 13, 2023

Uh oh!

codecov Bot commented Oct 13, 2023 •

edited

Loading

Uh oh!

ST-DDT commented Oct 14, 2023

Uh oh!

Uh oh!

ST-DDT commented Nov 1, 2023

Uh oh!

ST-DDT left a comment

Uh oh!

Uh oh!

Shinigami92 left a comment

Uh oh!

xDivisionByZerox commented Mar 10, 2024

Uh oh!

ST-DDT commented Mar 10, 2024

Uh oh!

netlify Bot commented Apr 6, 2024 •

edited

Loading

Uh oh!

xDivisionByZerox commented Apr 6, 2024 •

edited

Loading

Uh oh!

ST-DDT commented Apr 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

xDivisionByZerox commented Oct 13, 2023

Uh oh!

codecov Bot commented Oct 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ST-DDT commented Oct 14, 2023

Uh oh!

Uh oh!

ST-DDT commented Nov 1, 2023

Uh oh!

ST-DDT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Shinigami92 left a comment

Choose a reason for hiding this comment

Uh oh!

xDivisionByZerox commented Mar 10, 2024

Uh oh!

ST-DDT commented Mar 10, 2024

Uh oh!

netlify Bot commented Apr 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for fakerjs ready!

Uh oh!

xDivisionByZerox commented Apr 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ST-DDT commented Apr 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Oct 13, 2023 •

edited

Loading

netlify Bot commented Apr 6, 2024 •

edited

Loading

xDivisionByZerox commented Apr 6, 2024 •

edited

Loading