Skip to content

fix(locale): Dutch phone number#2400

Merged
ST-DDT merged 4 commits intofaker-js:nextfrom
RobinvanderVliet:patch-1
Sep 21, 2023
Merged

fix(locale): Dutch phone number#2400
ST-DDT merged 4 commits intofaker-js:nextfrom
RobinvanderVliet:patch-1

Conversation

@RobinvanderVliet
Copy link
Copy Markdown
Contributor

A Dutch phone number in national format consists of 10 digits. For mobile numbers, the second digit is always six. To obtain the international format, substitute the leading zero with "+31".

This pull request guarantees adherence to this format for all phone numbers and also includes examples of the international format.

@RobinvanderVliet RobinvanderVliet requested a review from a team as a code owner September 17, 2023 12:28
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 17, 2023

Codecov Report

Merging #2400 (7ae18cd) into next (da423b6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2400      +/-   ##
==========================================
+ Coverage   99.59%   99.61%   +0.01%     
==========================================
  Files        2801     2801              
  Lines      252469   252476       +7     
  Branches     1095     1104       +9     
==========================================
+ Hits       251458   251497      +39     
+ Misses        984      952      -32     
  Partials       27       27              
Files Changed Coverage Δ
src/locales/nl/phone_number/formats.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Comment thread src/locales/nl/phone_number/formats.ts
Comment thread src/locales/nl/phone_number/formats.ts
@ST-DDT ST-DDT requested review from a team September 17, 2023 13:26
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: phone Something is referring to the phone module labels Sep 17, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Sep 17, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) September 21, 2023 15:48
@ST-DDT ST-DDT merged commit 005369b into faker-js:next Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions m: phone Something is referring to the phone module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants