Skip to content

feat(locale): add commerce and company data for da#2378

Merged
ST-DDT merged 3 commits intofaker-js:nextfrom
stonor:da-locale-commerce-company
Sep 9, 2023
Merged

feat(locale): add commerce and company data for da#2378
ST-DDT merged 3 commits intofaker-js:nextfrom
stonor:da-locale-commerce-company

Conversation

@stonor
Copy link
Copy Markdown
Contributor

@stonor stonor commented Sep 4, 2023

Source: I translated the english data and added a couple of home made up company names and product descriptions.

@stonor stonor requested a review from a team as a code owner September 4, 2023 10:14
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 4, 2023

Codecov Report

Merging #2378 (b695c63) into next (8d7de9f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #2378    +/-   ##
========================================
  Coverage   99.60%   99.61%            
========================================
  Files        2770     2784    +14     
  Lines      251751   252492   +741     
  Branches     1083     1086     +3     
========================================
+ Hits       250764   251513   +749     
+ Misses        960      952     -8     
  Partials       27       27            
Files Changed Coverage Δ
src/locales/da/commerce/department.ts 100.00% <100.00%> (ø)
src/locales/da/commerce/index.ts 100.00% <100.00%> (ø)
src/locales/da/commerce/product_description.ts 100.00% <100.00%> (ø)
src/locales/da/commerce/product_name.ts 100.00% <100.00%> (ø)
src/locales/da/company/adjective.ts 100.00% <100.00%> (ø)
src/locales/da/company/buzz_adjective.ts 100.00% <100.00%> (ø)
src/locales/da/company/buzz_noun.ts 100.00% <100.00%> (ø)
src/locales/da/company/buzz_verb.ts 100.00% <100.00%> (ø)
src/locales/da/company/company_name.ts 100.00% <100.00%> (ø)
src/locales/da/company/descriptor.ts 100.00% <100.00%> (ø)
... and 5 more

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: commerce Something is referring to the commerce module m: company Something is referring to the company module labels Sep 4, 2023
@ST-DDT ST-DDT requested review from a team September 8, 2023 09:29
@ST-DDT ST-DDT enabled auto-merge (squash) September 9, 2023 06:24
@ST-DDT ST-DDT merged commit 604d52d into faker-js:next Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions m: commerce Something is referring to the commerce module m: company Something is referring to the company module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants