feat(locale): add database for German (de)#2226
Merged
Conversation
ghost
self-requested a review
as a 
xDivisionByZerox
added
c: feature
xDivisionByZerox
approved these changes
Jun 26, 2023
Member
xDivisionByZerox
left a comment
xDivisionByZerox
left a comment
There was a problem hiding this comment.
Thank you for your contribution. Those values look reasonable enough for me 👍
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2226 +/- ##
==========================================
- Coverage 99.60% 99.60% -0.01%
==========================================
Files 2637 2639 +2
Lines 245674 245709 +35
Branches 1154 1156 +2
==========================================
+ Hits 244699 244732 +33
- Misses 948 950 +2
Partials 27 27
|
ST-DDT
approved these changes
Jun 26, 2023
matthewmayer
approved these changes
Jun 27, 2023
ejcheng
approved these changes
Jun 27, 2023
Member
ejcheng
left a comment
ejcheng
left a comment
There was a problem hiding this comment.
Ran through Google Translate, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I extended the german locale (de) by adding data definitions for database.