fix(locale): rename city_prefix to city_name for en_NG, en_ZA, en_AU_ocker#2111
Merged
ST-DDT merged 4 commits intofaker-js:nextfrom May 1, 2023
Merged
Conversation
…ocker similar to faker-js#2109 for en_* locales
matthewmayer
added
m: location
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2111 +/- ##
==========================================
- Coverage 99.59% 99.59% -0.01%
==========================================
Files 2567 2567
Lines 243394 243394
Branches 1254 1251 -3
==========================================
- Hits 242420 242412 -8
- Misses 947 955 +8
Partials 27 27
|
ST-DDT
previously approved these changes
Apr 30, 2023
xDivisionByZerox
previously approved these changes
Apr 30, 2023
ejcheng
previously approved these changes
Apr 30, 2023
Member
|
Could you please resolve the conflicts by running the generate locales script again. Sorry for the inconvinience. |
# Conflicts: # src/locales/en_NG/location/index.ts # src/locales/en_ZA/location/index.ts
matthewmayer
dismissed stale reviews from ejcheng, xDivisionByZerox, and ST-DDT
via
f5eab34
ST-DDT
approved these changes
May 1, 2023
xDivisionByZerox
approved these changes
May 1, 2023
Shinigami92
approved these changes
May 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similar to #2109 for en_* locales