fix(locale): fix broken street address reference in fr_CH#2007
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2007 +/- ##
==========================================
+ Coverage 99.61% 99.62% +0.01%
==========================================
Files 2561 2561
Lines 243239 243239
Branches 1274 1280 +6
==========================================
+ Hits 242301 242331 +30
+ Misses 913 883 -30
Partials 25 25
|
Shinigami92
approved these changes
Apr 2, 2023
matthewmayer
approved these changes
Apr 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither fr
faker/src/locales/fr/location/index.ts
Lines 21 to 33 in caf58d9
Nor fr_CH
faker/src/locales/fr_CH/location/index.ts
Lines 23 to 37 in caf58d9
have
definitions.location.street_namefiles.Thus the pattern needs to be adjusted.
Found in #2004 (comment)